From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6D3328F507 for ; Fri, 9 May 2025 11:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746788751; cv=none; b=KCu9JrIWA1Axd+cRFdBc7+6gmGR+uXUQadfnl3FreWnyeB2Ld+MN3VbkzuQLUknAXVgCEwCsL/2QBYSxbmTKxNmgF6k4e9d7+Yl8+GZbtqGGH8+gSUmIlM5gjbKfpXFE0wS+2ZgMb9yAT3IPqfycy8+xBi1y6Lcd1eGYSVyC+EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746788751; c=relaxed/simple; bh=HtlxtTe7nrbfoONlv91HljKDl3ZjJxLieMuEZGdCo1o=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Mr3X7OrXLi0q2iq/99cd4KfVRp+mcp8EVRIhOA1ogcSFL5h1BtXhUESCvaAOzpr29G/hE3RYM+DTUyBkZC8K0aYYXFPeY0DTe0AGP0KRloEDvLYw4S3FtWWPcu3tNCcdmV5HVq+yExGxkB9MHKZ57RqDriw9TTzHqSZPOOZ/mgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lZsXp7D9; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lZsXp7D9" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-442ccf0e1b3so20914455e9.3 for ; Fri, 09 May 2025 04:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746788748; x=1747393548; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=irxrEhweCUXCqGm1VUjTuBVxoEJgZZgYdEdb4JaFlBI=; b=lZsXp7D95KXVzcde7g1yuRsj7nHKIvTgG01gyMaIZGQ2K6nMcKLoeUuZfiZg+j1PX9 ydhisSgcbeXQFEqYkuNuYJAXmTPa8ozAEnEYC9JFNJYcnuEpdvk6m94ZF8jTuKNTlKTy W3X/2JS/TVfyDFGsepnHfpsxL5D0T+sC7nzBNc2tATxNCDzkWq5h36H1A5pywB2+Mi0h GDyU6vCQd//l2GPAJPjgDe/p+gOwPC3tZIUrxxH6SmcGyYKciIM/67UymaYAiJkFyz49 tA2/pJj8y2bIGFfPpNf1rV5wJxcG160hOwYwXjHjDT1TJMPg14M8KJ9dgvQcOHTKf192 UQ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746788748; x=1747393548; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=irxrEhweCUXCqGm1VUjTuBVxoEJgZZgYdEdb4JaFlBI=; b=Y74JsPWiG+hl+CwyXYFP6PU94yx+dF+hquUZIQ4VMdn9yAjDZnIVcyNXkGsHEXh2g6 m8ipOWSyqBiQz7hvUugCTcEHRLUXJE49Tdv2FMD0SicJyX2vibw6TNbMpK8GhUjeSZ6q Vl1no4AJ7G2MxEeXebYnS4mUARCncf7JY7YwYahzOd7NzUJH/SdcuLrWBOsYeSpXu2oD gsIplvg4uje5iB3A7LEmzWjDPeQyy6aQ0A3fBNB4X7+VxGnYZJSDDFhI6z518/XDH8IN 3lFOesbJR7xaJq46CG3wF+AlN5MNevDXFjVrtVxx2O/cQ7iXelVtoxYLRdIPTyG5v9H0 icAQ== X-Forwarded-Encrypted: i=1; AJvYcCUAd/O6VrqIKvPJTj41fHIfdya4mthoH61pBYGvUOl7J+VNXbVaB+8HrtIp3IsUdIccStsrQjPbzuZhOFCjZbk=@vger.kernel.org X-Gm-Message-State: AOJu0YxkAG0ispmYM9BA2s58VoyqurJBH0c92aulD6ncI7zcpNrC/8sm jM3KVLINixm2b7+UUcFHK3jlBvzfpXVwos0OlGIW1I7xwsDNHLD7yuqJT89eXwc= X-Gm-Gg: ASbGncuKLHXp4FHEuZCKR+M2WzilbUD6Utu3jKxBe89CYl4fzAku76LML7QUgkIPunZ aFnMK6fL8cTrIxS16H+WRq0alefQzBpisW7DDVEDU0SjMdzXqBl+VrqQBq1nfx2LkE8+NShXFKs JBXgmHdhzW0LhV1R+vhqDli2EmBXw5Ug4zcFHywpkyXV9H96EeIg6Fhg14I666ZDSQ7a8OJFx4A cHJcQwN5cAyiPqL0AjQwGchKbhS/rn/eje98fo8tZ7IjoKuDKzwxoOdOG6/la52+tJntnCsuP2q mOpHt9WcZIZmrmM6Pkdcf/6vuMe2xbWfbSGWhR24jHoSMg== X-Google-Smtp-Source: AGHT+IH+jBPAUs3aXz3zrzpBM/2GBSQQqn+LzvaGfSuxOybuE/QO/NbJAsghIVYoGpfZOS2NV7eWLw== X-Received: by 2002:a05:600c:8714:b0:43d:fa59:a685 with SMTP id 5b1f17b1804b1-442d6ddf58cmr18396045e9.33.1746788748089; Fri, 09 May 2025 04:05:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a1f5a2d2c8sm2916601f8f.61.2025.05.09.04.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 May 2025 04:05:47 -0700 (PDT) Date: Fri, 9 May 2025 14:05:44 +0300 From: Dan Carpenter To: Shree Ramamoorthy Cc: Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Liam Girdwood , Mark Brown , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2 next] regulator: tps65219: regulator: tps65219: Fix error codes in probe() Message-ID: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding There is a copy and paste error and we accidentally use "PTR_ERR(rdev)" instead of "error". The "rdev" pointer is valid at this point. Also there is no need to print the error code in the error message because dev_err_probe() already prints that. So clean up the error message a bit. Fixes: 38c9f98db20a ("regulator: tps65219: Add support for TPS65215 Regulator IRQs") Signed-off-by: Dan Carpenter --- v2: Clean up the error message. Also fix a typo in the Subject drivers/regulator/tps65219-regulator.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c index b16b300d7f45..d80749cdae1d 100644 --- a/drivers/regulator/tps65219-regulator.c +++ b/drivers/regulator/tps65219-regulator.c @@ -454,9 +454,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev) irq_type->irq_name, &irq_data[i]); if (error) - return dev_err_probe(tps->dev, PTR_ERR(rdev), - "Failed to request %s IRQ %d: %d\n", - irq_type->irq_name, irq, error); + return dev_err_probe(tps->dev, error, + "Failed to request %s IRQ %d\n", + irq_type->irq_name, irq); } irq_data = devm_kmalloc(tps->dev, pmic->dev_irq_size, GFP_KERNEL); @@ -477,9 +477,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev) irq_type->irq_name, &irq_data[i]); if (error) - return dev_err_probe(tps->dev, PTR_ERR(rdev), - "Failed to request %s IRQ %d: %d\n", - irq_type->irq_name, irq, error); + return dev_err_probe(tps->dev, error, + "Failed to request %s IRQ %d\n", + irq_type->irq_name, irq); } return 0; -- 2.47.2