All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: "Waiman Long" <longman@redhat.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Xi Wang" <xii@google.com>
Subject: Re: [PATCH v2] cgroup/cpuset: Extend kthread_is_per_cpu() check to all PF_NO_SETAFFINITY tasks
Date: Fri, 9 May 2025 07:30:51 -1000	[thread overview]
Message-ID: <aB47y64qlbsnql07@slm.duckdns.org> (raw)
In-Reply-To: <aB4AmUtEM-qQ1Xoa@localhost.localdomain>

Hello,

On Fri, May 09, 2025 at 03:18:17PM +0200, Frederic Weisbecker wrote:
...
> But this makes me realize I overlooked that when I introduced the unbound kthreads
> centralized affinity.
> 
> cpuset_update_tasks_cpumask() seem to blindly affine to subpartitions_cpus
> while unbound kthreads might have their preferences (per-nodes or random cpumasks).
> 
> So I need to make that pass through kthread API.

I wonder whether it'd be cleaner if all kthread affinity restrictions go
through housekeeping instead of cpuset modifying the cpumasks directly so
that housekeeping keeps track of where different classes of kthreads can run
and tell e.g. workqueue what to do.

Thanks.

-- 
tejun

  parent reply	other threads:[~2025-05-09 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 19:24 [PATCH v2] cgroup/cpuset: Extend kthread_is_per_cpu() check to all PF_NO_SETAFFINITY tasks Waiman Long
2025-05-09 13:18 ` Frederic Weisbecker
2025-05-09 14:08   ` Waiman Long
2025-05-09 17:30   ` Tejun Heo [this message]
2025-05-09 21:19     ` Frederic Weisbecker
2025-05-09 17:35 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aB47y64qlbsnql07@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=frederic@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=xii@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.