From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B475C369CB for ; Tue, 29 Apr 2025 07:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 071EF6B0006; Tue, 29 Apr 2025 03:30:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 020FB6B0008; Tue, 29 Apr 2025 03:30:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E52C56B000A; Tue, 29 Apr 2025 03:30:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C45DE6B0006 for ; Tue, 29 Apr 2025 03:30:06 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 05517C83AD for ; Tue, 29 Apr 2025 07:30:08 +0000 (UTC) X-FDA: 83386257696.27.C64E586 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf16.hostedemail.com (Postfix) with ESMTP id 71FC6180014 for ; Tue, 29 Apr 2025 07:30:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iGFpLDyj; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745911806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MBq/kLyUoPPWNU+btElzODXfSh5uDYyaPAUI6RDbfjY=; b=suisPcrISapCO8Y9XTtqDnG8ZiOhOAvK93BL6dImCc6/azgONfw+yXlyGTCn6wc1akJNWT W4m8p+i8hDYJPuq4+7WS+/iVzTPTKd6Fwmmg0df1k/qNQOpvYlL9gbTYuGdIGA4WCD+vBT nvm5UwbaWnd3sbVFzw48gjqdiBAQ/JI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iGFpLDyj; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745911806; a=rsa-sha256; cv=none; b=kWtTAK2lIMXpFvSmnbn0UIQqDCpvkHXVoTGbGW/FKcFIl43qWlZ2cjotAdqF+7ScqYu/pb tiIJdsaBk+o4hkcBsyvFm+ireVQsJT/miVOuJ0aWWms3iVfDqk6rMyY7e3g5loTdBgp3m5 wDWW5gZ4n/G48sp+k7x7BZqbGqHmdvc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 19D3261166; Tue, 29 Apr 2025 07:29:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6E6CC4CEE3; Tue, 29 Apr 2025 07:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745911805; bh=DdqW1DSi43i5j7MIc7NAsvx6XJOuH9J0WeUBO3yn7+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iGFpLDyjQZSIcRLtlySHs5HUpYJh6aGm6SjGsEz2wkX2sVOuscJjh5kOLb/oeXRYI l8IDQz7K9Zjw7sgcQdzXYkVLt3S2lXR/81f8Rz3Aamu6A7LKlbrDUexz+StM+mCMAk y5LxM68R/KxJGoxvMl3moLFkAe5pBt+urWf9Vbz8oMbl19ZwAql1CJS7NvpY/9CVmx NJxa8Gpe7crYdEJKrIkVyORrmT4mDtiUREubS69hhPGRw2/IUsFXQVBaoiJEZu/jPM sbOFGImnmQbs4GtprZu8e8Cq4kOY1vLczZALemyC904SflMPqZ2tCW+SNYz1P48I3A z1uFPMO5E5Fwg== Date: Tue, 29 Apr 2025 10:29:58 +0300 From: Mike Rapoport To: Ye Liu Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn Subject: Re: [PATCH 2/3] mm/debug_page_alloc: improve error message for invalid guardpage minorder Message-ID: References: <20250427100442.958352-1-ye.liu@linux.dev> <20250427100442.958352-3-ye.liu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250427100442.958352-3-ye.liu@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 71FC6180014 X-Stat-Signature: d34b3xhuy666mtnfihnhoed4m996ox7z X-HE-Tag: 1745911806-362619 X-HE-Meta: U2FsdGVkX1/BLRkQwvm4nmTwv/LXysskUfYCRL6uuXv07tFZecVevoIDY8++ni4Yk1P9n+d9sJAL+EKj8vKohCa0n5DJG1FDNb9D8xKI6VoHIkygUm/Mhefah/vPhJDNIgU69XIgxRMaza+6QevTbGTZsk4s1R4Sg8vJLON72lz16Vk3SlXhIqhC+6X2h4cAJP3EhTgLo0LEZ5XoSKlBeuFNBWch17mxYaaCYw07BkB8e89VCpBfmaMMIRkGfF9vJ9KQHeApdUnV5dSXSwSHhtp/FGtDC27ZojotWNPvN/gGZ7Tew5ntIofRsTLLjI10K7jjRgNEGNqC2MngD2/sLfZSUeI1snVx3tXNsDbwEQPWEqjQm6RKZLooPfUMN21rhiJ8D1ZJ2PXytkKApu60OsUMasJWmNcz34gftstea58IyfrgMedLNd2eJlanr3yerC7Lek94zz2Rgfsm6znQ59PdbLYaMCsGTPgpn+dQzGwEY+njQ+I///0ZbZ4P2DKg6S7l93byRILtl4qqZusTbfDWia3TJccCsiPQHUXp8CBK7NTRAIifn8aihuTKN7nuasQMPHyyTRSxnfvr9Wu1LaL/1bCk16R4/QcRToPlPrsMtu4lhfuDGjkWcEBNIWUl5NYDsXzQEGS3xHqKbXAQnwNsnEug9XlpoJaOKRJIImfCBkjhqO65UV+8iaYK7NaENYFDzvl5nVSMCNuHTpMQeCGhBZHRDQi3HgisszD70m5AUINrMmQ7yntcGaGXc3nOmBXPMuh5K6ILeXiCznZPRekW7/kzb0qORYSGSDrO9FOBau32Q4YlxP460eRUs0szCHBmKaH0v/1VM3hL0z6LT6xaoW9BYjelpoEkIMpWx450Tw4ieWrGAnOnfX0i4R91NTDvhQ0eWa+kKdcExfFXNuPUO8bFEOSlaUJEhdDjnTZOzHOsI/GlDBcYPNiCkdKiG0RLDPfzh1CT7icQrDa mFqsWplr o/n2gdavu1ainaI35jyiBEqXmreucQDNdPkesoOwvIYUXloV5TXOYgZNKBagNvv+UCDYkz2Ic/XvsHl3BL1m7fAytMJamWp488J4zg497DJKlNeR9A+vaZFAPm0CBOv2PZJWWwirBKhL3Bsj5yCflTCBnYZzNwslAy0P+v3UokEROEYdc5J0FI3GVVhJWsV6iw53f0b3WxD0vo19DTccjlZUR520UEtQbqVdG5s3YOB5Sp0nwtOPFaeh/w95zDIR0GLkBxalfuN4CnI7I2o+w0/9g0g3CjwiC85vjNs0hVVr2Xy+BOiVstmzkdVZik2i4wucv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 27, 2025 at 06:04:41PM +0800, Ye Liu wrote: > From: Ye Liu > > When an invalid debug_guardpage_minorder value is provided, include the > user input in the error message. This helps users and developers diagnose > configuration issues more easily. > > No functional change. > > Signed-off-by: Ye Liu Acked-by: Mike Rapoport (Microsoft) > --- > mm/debug_page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/debug_page_alloc.c b/mm/debug_page_alloc.c > index d46acf989dde..6a26eca546c3 100644 > --- a/mm/debug_page_alloc.c > +++ b/mm/debug_page_alloc.c > @@ -23,7 +23,7 @@ static int __init debug_guardpage_minorder_setup(char *buf) > unsigned long res; > > if (kstrtoul(buf, 10, &res) < 0 || res > MAX_PAGE_ORDER / 2) { > - pr_err("Bad debug_guardpage_minorder value\n"); > + pr_err("Bad debug_guardpage_minorder value: %s\n", buf); > return 0; > } > _debug_guardpage_minorder = res; > -- > 2.25.1 > -- Sincerely yours, Mike.