Re: [PATCH 2/2] drm/i915/hdmi: Use an intel_connector pointer everywhere

[Imre Deak <imre.deak@intel.com>]

On Tue, Apr 29, 2025 at 01:36:41PM +0300, Jani Nikula wrote:
> On Mon, 28 Apr 2025, Imre Deak <imre.deak@intel.com> wrote:
> >  static void
> > -intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *connector)
> > +intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *_connector)
> >  {
> > +	struct intel_connector *connector = to_intel_connector(_connector);
> >  	struct intel_display *display = to_intel_display(intel_hdmi);
> >  
> > -	intel_attach_force_audio_property(connector);
> > -	intel_attach_broadcast_rgb_property(connector);
> > -	intel_attach_aspect_ratio_property(connector);
> > +	intel_attach_force_audio_property(&connector->base);
> > +	intel_attach_broadcast_rgb_property(&connector->base);
> > +	intel_attach_aspect_ratio_property(&connector->base);
> 
> A guess a follow-up could convert all of these and more to accept
> intel_connector as parameter.

Yes, all the intel_attach_*_property() functions look convertable now
for all output types. Can do that as well at one point, unless someone
else does it.

> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel