All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jakub Brnak <jbrnak@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	kan.liang@linux.intel.com, mpetlan@redhat.com,
	tglozar@redhat.com, Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH v3] perf test probe_vfs_getname: Skip if no suitable line detected
Date: Tue, 29 Apr 2025 12:02:13 -0300	[thread overview]
Message-ID: <aBDp9fU5qJJeP9z3@x1> (raw)
In-Reply-To: <Z_gw-xw97c_IWdXw@google.com>

On Thu, Apr 10, 2025 at 01:58:35PM -0700, Namhyung Kim wrote:
> Hello,
> 
> On Thu, Apr 10, 2025 at 04:32:11PM +0200, Jakub Brnak wrote:
> > On Mon, Mar 24, 2025 at 03:45:23PM +0100, Jakub Brnak wrote:
> > > In some cases when calling function add_probe_vfs_getname, line number
> > > can't be detected by perf probe -L getname_flags:
> > > 
> > >   78         atomic_set(&result->refcnt, 1);
> > > 
> > > 	     // one of the following lines should have line number
> > > 	     // but sometimes it does not because of optimization
> > > 	     result->uptr = filename;
> > >              result->aname = NULL;
> > > 
> > >   81         audit_getname(result);
> > > 
> > > To prevent false failures, skip the affected tests
> > > if no suitable line numbers can be detected.
> > > 
> > > Signed-off-by: Jakub Brnak <jbrnak@redhat.com>
> 
> Sorry for the long delay.  It looks ok to me.
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied to perf-tools-next,

- Arnaldo

      reply	other threads:[~2025-04-29 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24 14:45 [PATCH v3] perf test probe_vfs_getname: Skip if no suitable line detected Jakub Brnak
2025-04-10 14:32 ` Jakub Brnak
2025-04-10 20:58   ` Namhyung Kim
2025-04-29 15:02     ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBDp9fU5qJJeP9z3@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jbrnak@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.