From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Harry Yoo <harry.yoo@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH v2 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes
Date: Wed, 30 Apr 2025 10:47:51 +0200 [thread overview]
Message-ID: <aBHjt9D7m03FOPCJ@localhost.localdomain> (raw)
In-Reply-To: <60ae4d6b-3ace-482b-9945-1261003f3785@redhat.com>
On Tue, Apr 08, 2025 at 08:18:32PM +0200, David Hildenbrand wrote:
> We could by grabbing the mutex in MEM_GOING_ONLINE and putting it in
> MEM_CANCEL_ONLINE / MEM_ONLINE when a node is going online.
Hi guys,
After a few busy days I have been revisiting this.
I checked the proposal of slab_mutex spanning GOING_ONLINE <-> ONLINE,
and I did not see any issue.
The only concern I had is that we might be calling some slab function from
{online,offline}_pages() that also takes the mutex.
I am not aware of any though, and quickly checking did not reveal
anything either.
If there is any will be quickly revealed though :-).
So, unless there is an opposition, I can move forward and see how it
looks.
Thoughts?
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-04-30 8:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 8:41 [PATCH v2 0/3] Implement numa node notifier Oscar Salvador
2025-04-08 8:41 ` [PATCH v2 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Oscar Salvador
2025-04-08 10:17 ` David Hildenbrand
2025-04-08 12:49 ` Oscar Salvador
2025-04-08 15:15 ` Harry Yoo
2025-04-08 14:18 ` Harry Yoo
2025-04-08 14:25 ` David Hildenbrand
2025-04-08 14:54 ` Harry Yoo
2025-04-08 17:55 ` Vlastimil Babka
2025-04-08 18:18 ` David Hildenbrand
2025-04-30 8:47 ` Oscar Salvador [this message]
2025-04-30 8:57 ` Vlastimil Babka
2025-04-30 9:02 ` David Hildenbrand
2025-04-08 8:41 ` [PATCH v2 2/3] mm,memory_hotplug: Implement numa node notifier Oscar Salvador
2025-04-09 13:44 ` kernel test robot
2025-04-09 16:58 ` Oscar Salvador
2025-04-08 8:41 ` [PATCH v2 3/3] mm,memory_hotplug: Rename status_change_nid parameter in memory_notify Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBHjt9D7m03FOPCJ@localhost.localdomain \
--to=osalvador@suse.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=harry.yoo@oracle.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.