From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Vijendar Mukunda" <Vijendar.Mukunda@amd.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v1 1/2] ASoC: intel/sdw_utils: Add volume limit to cs42l43 speakers
Date: Wed, 30 Apr 2025 13:05:48 +0100 [thread overview]
Message-ID: <aBISHAyAHPMB/wkW@opensource.cirrus.com> (raw)
In-Reply-To: <20250430103134.24579-2-sbinding@opensource.cirrus.com>
On Wed, Apr 30, 2025 at 11:31:19AM +0100, Stefan Binding wrote:
> The volume control for cs42l43 speakers has a maximum gain of +31.5 dB.
> However, for many use cases, this can cause distorted audio, depending
> various factors, such as other signal-processing elements in the chain,
> for example if the audio passes through a gain control before reaching
> the codec or the signal path has been tuned for a particular maximum
> gain in the codec.
>
> In the case of systems which use the soc_sdw_cs42l43 driver, audio will
> likely be distorted in all cases above 0 dB, therefore add a volume
> limit of 128, which is 0 dB maximum volume inside this driver.
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2025-04-30 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 10:31 [PATCH v1 0/2] ASoC: intel/sdw_utils: Add volume limits to CS35L56 and CS42L43 speakers Stefan Binding
2025-04-30 10:31 ` [PATCH v1 1/2] ASoC: intel/sdw_utils: Add volume limit to cs42l43 speakers Stefan Binding
2025-04-30 12:05 ` Charles Keepax [this message]
2025-04-30 10:31 ` [PATCH v1 2/2] ASoC: intel/sdw_utils: Add volume limit to cs35l56 speakers Stefan Binding
2025-05-01 6:38 ` [PATCH v1 0/2] ASoC: intel/sdw_utils: Add volume limits to CS35L56 and CS42L43 speakers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBISHAyAHPMB/wkW@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=sbinding@opensource.cirrus.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.