From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
linux-input@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH] Input: edt-ft5x06 - use per-client debugfs directory
Date: Thu, 1 May 2025 07:48:48 +0200 [thread overview]
Message-ID: <aBMLQLv2cm1RXgTq@shikoro> (raw)
In-Reply-To: <6rid4lbtyisgchnl4grnwzysrbw2wtd4lrkjmw5tcs4xyggafo@tondbi5jhl5w>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On Wed, Apr 30, 2025 at 08:13:08PM -0700, Dmitry Torokhov wrote:
> Hi Wolfram,
>
> On Tue, Mar 18, 2025 at 10:17:41AM +0100, Wolfram Sang wrote:
> > The I2C core now provides a debugfs entry for each client. Let this
> > driver use it instead of the custom directory in debugfs root. Further
> > improvements by this change: support of multiple instances.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> >
> > Build tested only, by me and buildbots. Trying to cleanup the debugfs a
> > little. But not sure if this is too complicated for users. Opinions?
>
> This looks nice and nobody is yelling. Any reason why I shouldn't simply
> apply it?
Not really. I marked this as RFC because the path changed from
/sys/kernel/debug/edt_ft5x06
to
/sys/kernel/debug/i2c/<i2c-bus>/<i2c-device>/
so people have to deal with bus and device numbers now. I usually think
debugfs is mostly for developers, so they can handle that. I wasn't so
sure with this driver for some reason...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-05-01 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 9:17 [RFC PATCH] Input: edt-ft5x06 - use per-client debugfs directory Wolfram Sang
2025-05-01 3:13 ` Dmitry Torokhov
2025-05-01 5:48 ` Wolfram Sang [this message]
2025-07-01 18:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBMLQLv2cm1RXgTq@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.