From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}
Date: Mon, 5 May 2025 01:39:29 +0000 [thread overview]
Message-ID: <aBgW0UXKC7ZUo49S@gallifrey> (raw)
In-Reply-To: <c92a8101-e8fe-4727-9f85-e1e96ef5392c@RTEXMBS04.realtek.com.tw>
* Ping-Ke Shih (pkshih@realtek.com) wrote:
> linux@treblig.org wrote:
>
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > rtl_usb_resume() and rtl_usb_suspend() are trivial stubs that were
> > added in 2011's
> > commit 2ca20f79e0d8 ("rtlwifi: Add usb driver")
> > but aren't wired up anywhere (though commit 442888c706e9 ("rtlwifi:
> > rtl8192cu: Add routines dm, fw, led and sw") added commented
> > out assignments).
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> 3 patch(es) applied to rtw-next branch of rtw.git, thanks.
>
> d559636e382a wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}
> 2d867b18eb93 wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibrate
> 406dac790c25 wifi: rtlwifi: Remove unused rtl_bb_delay()
Thanks!
Did you see the question in the 0/3 cover letter asking why
rtl8188ee_bt_hw_init() isn't called?
Dave
> ---
> https://github.com/pkshih/rtw.git
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2025-05-05 1:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 23:53 [PATCH 0/3] rtlwifi deadcoding linux
2025-04-25 23:53 ` [PATCH 1/3] wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend} linux
2025-05-05 1:31 ` Ping-Ke Shih
2025-05-05 1:39 ` Dr. David Alan Gilbert [this message]
2025-05-05 2:07 ` Ping-Ke Shih
2025-04-25 23:53 ` [PATCH 2/3] wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibrate linux
2025-04-25 23:53 ` [PATCH 3/3] wifi: rtlwifi: Remove unused rtl_bb_delay() linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBgW0UXKC7ZUo49S@gallifrey \
--to=linux@treblig.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.