From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com,
peter.ujfalusi@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
pierre-louis.bossart@linux.dev, Vijendar.Mukunda@amd.com,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH 1/2] ASoC: sdw_utils: Remove num_platforms from simple DAI helper
Date: Mon, 5 May 2025 09:23:11 +0100 [thread overview]
Message-ID: <aBh1b1AvNImHEnHI@opensource.cirrus.com> (raw)
In-Reply-To: <aBav5YeU5-TNHoEQ@finisterre.sirena.org.uk>
On Sun, May 04, 2025 at 09:08:05AM +0900, Mark Brown wrote:
> On Tue, Apr 29, 2025 at 10:39:30AM +0100, Charles Keepax wrote:
> > There is no point in passing num_platforms into
> > asoc_sdw_init_simple_dai_link(). Firstly, as a single pointer for the
> > component name is passed in only a single string can be passed and
> > secondly if it is a complex DAI with multiple platforms it would make
> > more sense to use asoc_sdw_init_dai_link().
>
> > Fixes: 59f8b622d52e ("ASoC: intel/sdw_utils: refactor init_dai_link() and init_simple_dai_link()")
>
> The changelog doesn't seem to describe a bug here...
Yeah that is fair this probably is more of a clean up, I will
resend and drop the fixes.
Thanks,
Charles
prev parent reply other threads:[~2025-05-05 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 9:39 [PATCH 1/2] ASoC: sdw_utils: Remove num_platforms from simple DAI helper Charles Keepax
2025-04-29 9:39 ` [PATCH 2/2] ASoC: Intel: sof_sdw: Don't bother to set platform string Charles Keepax
2025-05-04 0:09 ` Mark Brown
2025-05-05 8:24 ` Charles Keepax
2025-05-04 0:08 ` [PATCH 1/2] ASoC: sdw_utils: Remove num_platforms from simple DAI helper Mark Brown
2025-05-05 8:23 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBh1b1AvNImHEnHI@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.