From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Zhongqiu Duan <dzq.aishenghu0@gmail.com>
Cc: coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH nf-next v2] netfilter: nft_quota: match correctly when the quota just depleted
Date: Mon, 5 May 2025 13:16:02 +0200 [thread overview]
Message-ID: <aBid8mozezsMFv_F@calendula> (raw)
In-Reply-To: <20250417154932.314972-1-dzq.aishenghu0@gmail.com>
On Thu, Apr 17, 2025 at 03:49:30PM +0000, Zhongqiu Duan wrote:
> The xt_quota compares skb length with remaining quota, but the nft_quota
> compares it with consumed bytes.
>
> The xt_quota can match consumed bytes up to quota at maximum. But the
> nft_quota break match when consumed bytes equal to quota.
>
> i.e., nft_quota match consumed bytes in [0, quota - 1], not [0, quota].
Yes, quota is off by one.
Applied to nf-next, thanks.
prev parent reply other threads:[~2025-05-05 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 15:49 [PATCH nf-next v2] netfilter: nft_quota: match correctly when the quota just depleted Zhongqiu Duan
2025-05-05 11:16 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBid8mozezsMFv_F@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=dzq.aishenghu0@gmail.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.