From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 885AF2522B1 for ; Mon, 5 May 2025 14:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746455248; cv=none; b=e5qcRpc2B3C650GDFSdYE5VmbobQ++DrBfM57ZLCTG+R9OhBAYPl1NIKk3x1X7Pm4dwJPUn/Bgv0CQWcgmSidqS+j3WPT7qLyjU7JKaXIOYU7J5YvzEfMedlU3Rt7X/wtmdc2kgNzWDpaupEyddZIhpwHzKHV8D0B2cNA5koFe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746455248; c=relaxed/simple; bh=Ly0CvE3a7Ft2cguZwUX08mOhOyHbvdJxbcYNTMDul48=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=JerEDi6aIUfPl181dIRy5+h3ajTrSCyPloa+KywGMDd04+MirTofWTOfHfCar8HWk9FLI+uDiX4xEj+ZqVkUI080zI6U0gVgSM6YAxdUyR22JemsyugvNvgNIwtYf3LJeSAY9LXntsJ8Y2vUbUseLfJa4nWnyVNxLZQvt2lDOSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hw9zGMpK; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hw9zGMpK" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43cfecdd8b2so28061485e9.2 for ; Mon, 05 May 2025 07:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746455245; x=1747060045; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=oAtVszf1vdrmHz2MZSZ/fpRznhrZHx8AbHdFOY7qIPA=; b=hw9zGMpKmVUHTAtRLOzfTBFRB2Mgum2BJuCXuGBnWHTC+aN6ruDP/oTg6iqSUJL0eW iErNIwjpqpqYBeIu5SvADdpPFSG6U58CIrLnqVF5h47cfBaWm4bJUtlrEbOMYpWLRBVV K17JdBBJ8ZFVs+yjm+4k0sy3jNAERytEnjVYNc6Vq+VZL1uT9F+PP0cDU91fnvFMPW4I FStqDEPzemnzZZE7SkYSkl40X+8d5aV/KrU2nAez87aAMRWzi+KUM3kWbanJf8OgbJm7 GEacw5DSq+YN2I3iZDYASIzKhrHQl+90HN+1xXKbHned67p9NBJeZsofmcwkC9g57HqJ LLug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746455245; x=1747060045; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oAtVszf1vdrmHz2MZSZ/fpRznhrZHx8AbHdFOY7qIPA=; b=uujr+Ss1ReTE1Z5WjA9gG9nSAodCDrH/9ZljQlHjYlh1BlttP0ik2uAraBzhP0y/fA X8YDX3VhDDbX6UyQNZ14Msynhkn9CNzeci+QpUz5hf/kb1X9UZXUeqLHB00WOCzSAwy9 fR+fgm4yELz+oRYhzrR+p5mYIfalkRwaUl9D9oIiDRbPAXBgC25IHG4woiY/uS0JEGGZ mV6uoTR3esIE+B0UGFWffYzNWEoBHp6qy13ri3XMlNUycrghRRIq80Qc7hyhubV7eMRi Lec7NF6nBNU/AEEInOeLWzhldvyqS2v+Na67d5KeJizI7KirlAyq2uY1NhSrIQyhoYuS u+gw== X-Forwarded-Encrypted: i=1; AJvYcCV1Hn4jKTWKWrzNzDwcBdckeDjlNMuupdmlh8H/rVFDYl3AIa536f3I0FuVY6fXuI79zuXntm4x16cN37S4IhE=@vger.kernel.org X-Gm-Message-State: AOJu0YxNzEvFBAqqpKXTutkKWZEsHOy2gX/hpOZGgjh9vGrpyppIMljK 7iZXfE31yldCUMXFbVpxjnZxpVRIR5Ub0MtiTZAKW51cUJsza4D9h3i6SkO8Bwc= X-Gm-Gg: ASbGncvc1OwiJclHcYa0jTI8dx+DvEgw1QuijDDHXk+8vBLJio8HBN6RXua0Au7wzy1 CeDdZDSmViw5i1x/hFe/rwotIso8cEkUjFBYCv3LX+GQGGLXu19kY6nqD6Q9QqlYpyOkQ+H3YLo NjxtVUW+/C+oxGWVpsFR3rek1SF/XZFu6OH9zDJiaumo6o5SlNjSE55YYGEH4i7HW9lKdeW3nRy gwN3Z8dyn01YMa+afWn+XHufBFYDe7wZ1fUGnu0uHxznmdJ48iwD7lCFi8X2fALmg3+DMZMm2Wm 6sEtnR/w07CD5Ir/8t8wJcCpYrxXXq23SaOOiIDTiTTL7A== X-Google-Smtp-Source: AGHT+IHdZ4eHWjSeHJWyp03pTCeFtVQb1fWivNtID+bl+XU3/4RJV+jvA1o2S7f/8WrZbEMT8MT8Rw== X-Received: by 2002:a05:600c:3494:b0:43c:f5fe:5c26 with SMTP id 5b1f17b1804b1-441c48aa314mr72504945e9.4.1746455244822; Mon, 05 May 2025 07:27:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-441b2aecb60sm180087725e9.11.2025.05.05.07.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 07:27:24 -0700 (PDT) Date: Mon, 5 May 2025 17:27:20 +0300 From: Dan Carpenter To: Shyam Prasad N Cc: Steve French , Paulo Alcantara , Ronnie Sahlberg , Tom Talpey , Bharath SM , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] cifs: Fix double unlock bug in open_cached_dir() Message-ID: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The "goto out;" also does mutex_unlock(&cfid->cfid_mutex) so delete this duplicate unlock. Fixes: 62adfb82c199 ("cifs: serialize initialization and cleanup of cfid") Signed-off-by: Dan Carpenter --- To be honest I suspect that we're going to have to revert 62adfb82c199 ("cifs: serialize initialization and cleanup of cfid") instead of fixing it? So this patch might not be worth applying. fs/smb/client/cached_dir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c index 9e20e3dc2c03..3f4fe1ecdcaf 100644 --- a/fs/smb/client/cached_dir.c +++ b/fs/smb/client/cached_dir.c @@ -238,7 +238,6 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon, */ npath = path_no_prefix(cifs_sb, path); if (IS_ERR(npath)) { - mutex_unlock(&cfid->cfid_mutex); rc = PTR_ERR(npath); goto out; } -- 2.47.2