From: Tejun Heo <tj@kernel.org>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH] kernel/cgroup/pids: add "pids.forks" counter
Date: Mon, 5 May 2025 06:31:45 -1000 [thread overview]
Message-ID: <aBjn8epxUXDOomiu@slm.duckdns.org> (raw)
In-Reply-To: <CAKPOu+_Dk7rLgc+5YbMd4xpcjz74XKnR1jkgaTxu81EvE-q1-g@mail.gmail.com>
On Mon, May 05, 2025 at 02:49:09PM +0200, Max Kellermann wrote:
> On Fri, May 2, 2025 at 8:37 PM Tejun Heo <tj@kernel.org> wrote:
> > +1 on pids.stat, and use rstat and avoid the atomic ops?
>
> rstat right now is specific to the "cpu" controller. There is "struct
> cgroup_rstat_cpu". And there is "struct cgroup_base_stat", but that is
> also specific to the "cpu" controller.
Oh, it's not specific to the cpu controller. The cpu part is just special.
Please see e.g. how blkcg or memcg uses rstat.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-05-05 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 12:19 [PATCH] kernel/cgroup/pids: add "pids.forks" counter Max Kellermann
2025-05-02 12:55 ` Michal Koutný
2025-05-02 13:23 ` Max Kellermann
2025-05-02 13:56 ` Michal Koutný
2025-05-02 18:37 ` Tejun Heo
2025-05-05 12:49 ` Max Kellermann
2025-05-05 16:31 ` Tejun Heo [this message]
2025-05-05 19:52 ` Max Kellermann
2025-05-05 21:15 ` Tejun Heo
2025-05-06 15:30 ` [PATCH PoC] kernel/cgroup/pids: refactor "pids.forks" into "pids.stat" Max Kellermann
2025-05-12 10:20 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBjn8epxUXDOomiu@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.