From: Stanislav Fomichev <stfomichev@gmail.com>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: netdev@vger.kernel.org, Stanislav Fomichev <sdf@fomichev.me>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"jiri @ resnulli . us" <jiri@resnulli.us>,
Saeed Mahameed <saeedm@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] net: Lock netdevices during dev_shutdown
Date: Mon, 5 May 2025 18:10:32 -0700 [thread overview]
Message-ID: <aBlhiI7V0EQWEmzk@mini-arch> (raw)
In-Reply-To: <20250505194713.1723399-1-cratiu@nvidia.com>
On 05/05, Cosmin Ratiu wrote:
> __qdisc_destroy() calls into various qdiscs .destroy() op, which in turn
> can call .ndo_setup_tc(), which requires the netdev instance lock.
>
> This commit extends the critical section in
> unregister_netdevice_many_notify() to cover dev_shutdown() (and
> dev_tcx_uninstall() as a side-effect) and acquires the netdev instance
> lock in __dev_change_net_namespace() for the other dev_shutdown() call.
>
> This should now guarantee that for all qdisc ops, the netdev instance
> lock is held during .ndo_setup_tc().
>
> Fixes: a0527ee2df3f ("net: hold netdev instance lock during qdisc ndo_setup_tc")
> Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Thanks!
next prev parent reply other threads:[~2025-05-06 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 19:47 [PATCH net] net: Lock netdevices during dev_shutdown Cosmin Ratiu
2025-05-06 1:10 ` Stanislav Fomichev [this message]
2025-05-07 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBlhiI7V0EQWEmzk@mini-arch \
--to=stfomichev@gmail.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.