From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E21EC3ABBE for ; Wed, 7 May 2025 01:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kKkgCYl7QDp/mF2HadETYtq9IkDDn2xPx3i9MZ/RBik=; b=HrJAoZk7PKmLae0pXMEU/kE/zL H7e35eacDEw5y5v8HmU819r4Jq/rC2STrs86sDglIzb1NbLupUic5GjhGYZYfN7SGQ3ymoZ8qL8h6 hSkZz6UCehQYDB1fPoyQ07R/esGEMOxyAmQuPN+ZVNVg96C1Z0Dz1by2Pypje+eH9t+0=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uCTW4-00067z-AH; Wed, 07 May 2025 01:24:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uCTW3-00067s-6c for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 01:24:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y53Or0ju7IW3r8d/UGisGDsEA5/7L7BTCG1Mu1G2cQs=; b=KW8bec9VfMNsL7RT+1dNVjOxuc Qx6gFFd7xESkdL27w0Q56F4DocqJKc3sEvGWWvbnMKOVhrUy1ahWFzU1x0kmLlqOTsyj8waln7hmE hTvO0w6oMJcfomCJQbiAhcUYLUrhjrz2TnxYVz1V3SGlrTi83b/xBsPOgrE29jrRW2bI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y53Or0ju7IW3r8d/UGisGDsEA5/7L7BTCG1Mu1G2cQs=; b=cWAjHXmBrvpKLxuIDa7Z5NYWIl Yf0u9CQJ+GvtsoHitOac8OUmMoaWaKj7gDDdjUOcBnP0TEbenlhlQ5vCW/zkrfAteBdGU4ded8o/w +jggUaFj0dj52b3h3g+o2w1Rxkhibyt/yhgsgUkKkmQ64rbZhyPt3dVa1dqv3k3HMkBE=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uCTVn-0004Ip-DY for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 01:24:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id EE4F949C0A; Wed, 7 May 2025 01:23:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BC2EC4CEE4; Wed, 7 May 2025 01:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746581020; bh=F4eggE/XuvmFU6Dzpov5lbcFYVF1XKoy/tEW6B4VUpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWSCbLO7kICn4t9yIanA0ANkvU/GeY08csO1HjIbMev00UHlhYwxHXSF6mR9hKD1q zL47fz8tUvnTBBFnq0aoXz+QUa0XpDvneSQaqWUQDnp2bSMtcJbb91vGtQed1a1Spv CDDKNrLOzA5Ojwx6NnVc47Q43ZNl/oUalMsiNbFiSRLKvcxdDQlCRgD3dnfp2ywe+F rp01ZSc9HIZc82kTJbe4XbWhiQm0oPmMfiaxG9NoDpJZpPQzt0KMOf9+ofJEr/D6n8 HjZBCRPe41Td4wK0ILNU+RfUhK2NjHQ/THLKbY/CKz3WRg/EMJbV3MK2gZsvla7Qye tGgjpWz1ODIxQ== Date: Wed, 7 May 2025 01:23:38 +0000 To: Eric Sandeen Message-ID: References: <20250423170926.76007-1-sandeen@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1uCTVn-0004Ip-DY Subject: Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: linux-fsdevel@vger.kernel.org, lihongbo22@huawei.com, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/06, Eric Sandeen wrote: > On 5/6/25 7:35 PM, Jaegeuk Kim wrote: > > Hmm, I had to drop the series at the moment, since it seems needing more > > work to deal with default_options(), which breaks my device setup. > > For example, set_opt(sbi, READ_EXTENT_CACHE) in default_options is not propagating > > to the below logics. In this case, do we need ctx_set_opt() if user doesn't set? > > Hm, can you describe the test or environment that fails for you? > (I'm afraid that I may not have all the right hardware to test everything, > so may have missed some cases) > > However, from a quick test here, a loopback mount of an f2fs image file does > set extent_cache properly, so maybe I don't understand the problem: > > # mount -o loop f2fsfile.img mnt > # mount | grep -o extent_cache > extent_cache > # > > I'm happy to try to look into it though. Maybe you can put the patches > back on a temporary branch for me to pull and test? Thank you! I pushed here the last version. https://github.com/jaegeuk/f2fs/commits/mount/ What about: # mount -o loop,noextent_cache f2fsfile.img mnt In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options, 3) clear_opt since mask is set? And, device_aliasing check is still failing, since it does not understand test_opt(). Probably it's the only case? > > Thanks, > - Eric > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0556B13AA3E for ; Wed, 7 May 2025 01:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746581021; cv=none; b=i3Z68uDm0rf2BtR7UiL6gVkzcShCz8Gg4fJH6H+n6ntQm1+hFyNE8HUcflxYUMztNzELI0fcMUR7VYzLx9lxMk60YkVPpVmVt/DjeW2YYkudFFKTuYcWpe2tyYwtx5j+AbP44p72yQIQUd1jJwU+6jmPLIDsNd4rVnpYNh1n0aY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746581021; c=relaxed/simple; bh=F4eggE/XuvmFU6Dzpov5lbcFYVF1XKoy/tEW6B4VUpE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K73ytfqOixOvFIzolln03aEFo4aDOQBG1iDMBmIrm5E8vHqaNmS7HcmPBQQ6Ry2q9+aC2aVEhXCxmK1oBmLrX6zZww/gT5lg89kmAKe17DFRYIYBQkSoSSrsiEgEZjrb+CxOF08rMZQEb6ZytMuyWpvEEDMJcWsc6WzAQryVZuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BWSCbLO7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BWSCbLO7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BC2EC4CEE4; Wed, 7 May 2025 01:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746581020; bh=F4eggE/XuvmFU6Dzpov5lbcFYVF1XKoy/tEW6B4VUpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWSCbLO7kICn4t9yIanA0ANkvU/GeY08csO1HjIbMev00UHlhYwxHXSF6mR9hKD1q zL47fz8tUvnTBBFnq0aoXz+QUa0XpDvneSQaqWUQDnp2bSMtcJbb91vGtQed1a1Spv CDDKNrLOzA5Ojwx6NnVc47Q43ZNl/oUalMsiNbFiSRLKvcxdDQlCRgD3dnfp2ywe+F rp01ZSc9HIZc82kTJbe4XbWhiQm0oPmMfiaxG9NoDpJZpPQzt0KMOf9+ofJEr/D6n8 HjZBCRPe41Td4wK0ILNU+RfUhK2NjHQ/THLKbY/CKz3WRg/EMJbV3MK2gZsvla7Qye tGgjpWz1ODIxQ== Date: Wed, 7 May 2025 01:23:38 +0000 From: Jaegeuk Kim To: Eric Sandeen Cc: linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, chao@kernel.org, lihongbo22@huawei.com Subject: Re: [PATCH V3 0/7] f2fs: new mount API conversion Message-ID: References: <20250423170926.76007-1-sandeen@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 05/06, Eric Sandeen wrote: > On 5/6/25 7:35 PM, Jaegeuk Kim wrote: > > Hmm, I had to drop the series at the moment, since it seems needing more > > work to deal with default_options(), which breaks my device setup. > > For example, set_opt(sbi, READ_EXTENT_CACHE) in default_options is not propagating > > to the below logics. In this case, do we need ctx_set_opt() if user doesn't set? > > Hm, can you describe the test or environment that fails for you? > (I'm afraid that I may not have all the right hardware to test everything, > so may have missed some cases) > > However, from a quick test here, a loopback mount of an f2fs image file does > set extent_cache properly, so maybe I don't understand the problem: > > # mount -o loop f2fsfile.img mnt > # mount | grep -o extent_cache > extent_cache > # > > I'm happy to try to look into it though. Maybe you can put the patches > back on a temporary branch for me to pull and test? Thank you! I pushed here the last version. https://github.com/jaegeuk/f2fs/commits/mount/ What about: # mount -o loop,noextent_cache f2fsfile.img mnt In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options, 3) clear_opt since mask is set? And, device_aliasing check is still failing, since it does not understand test_opt(). Probably it's the only case? > > Thanks, > - Eric >