All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: alexander.deucher@amd.com, kenneth.feng@amd.com,
	christian.koenig@amd.com
Cc: amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: questions about smu_mode2_reset_is_support and smu_v13_0_init_display_count
Date: Wed, 7 May 2025 00:32:10 +0000	[thread overview]
Message-ID: <aBqqCmYICO_C0nLT@gallifrey> (raw)

Hi,
  I noticed two functions that are unused but I wasn't sure what to
do with them:

smu_v13_0_init_display_count() isn't called/wired up, where as the
v11 version is wired up:

 drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
     3574:	.init_display_count = smu_v11_0_init_display_count,

so is v13 really unused or should it be wired up in a similar way?

secondly, smu_mode2_reset_is_support() is uncalled, but it's
the only caller through the mode2_reset_is_support() function
pointer; so if smu_mode2_reset_is_support() was deleted, does
it then make sense to clean up all of
  sienna_cichlid_is_mode2_reset_supported,
  aldebaran_is_mode2_reset_supported,
  smu_v13_0_6_is_mode2_reset_supported

which that function pointer is sett to.

Thanks in advance,

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

             reply	other threads:[~2025-05-07  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07  0:32 Dr. David Alan Gilbert [this message]
2025-05-07  2:21 ` questions about smu_mode2_reset_is_support and smu_v13_0_init_display_count Feng, Kenneth
2025-05-07 17:22   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBqqCmYICO_C0nLT@gallifrey \
    --to=linux@treblig.org \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=kenneth.feng@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.