From: Zhao Liu <zhao1.liu@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Laurent Vivier" <lvivier@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Amit Shah" <amit@kernel.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Sergio Lopez" <slp@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Clément Mathieu--Drif" <clement.mathieu--drif@eviden.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Yi Liu" <yi.l.liu@intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Mark Cave-Ayland" <mark.caveayland@nutanix.com>
Subject: Re: [PATCH v3 02/19] hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field
Date: Wed, 7 May 2025 14:23:34 +0800 [thread overview]
Message-ID: <aBr8Zknwle47ljOB@intel.com> (raw)
In-Reply-To: <20250502185652.67370-3-philmd@linaro.org>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 3fffa4a3328..625889783ec 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1465,9 +1465,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> }
> aml_append(dsdt, scope);
>
> - if (pcmc->legacy_cpu_hotplug) {
> - build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base);
> - } else {
> + {
Why leave the {} here? for clarity?
> CPUHotplugFeatures opts = {
> .acpi_1_compatible = true, .has_legacy_cphp = true,
> .smi_path = pm->smi_on_cpuhp ? "\\_SB.PCI0.SMI0.SMIC" : NULL,
Otherwise,
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2025-05-07 6:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 18:56 [PATCH v3 00/19] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 01/19] hw/i386/pc: Remove deprecated pc-q35-2.6 and pc-i440fx-2.6 machines Philippe Mathieu-Daudé
2025-05-07 6:10 ` Zhao Liu
2025-05-02 18:56 ` [PATCH v3 02/19] hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field Philippe Mathieu-Daudé
2025-05-07 6:23 ` Zhao Liu [this message]
2025-05-08 13:02 ` Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 03/19] hw/mips/loongson3_virt: Prefer using fw_cfg_init_mem() Philippe Mathieu-Daudé
2025-05-07 6:31 ` Zhao Liu
2025-05-07 11:59 ` Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 04/19] hw/nvram/fw_cfg: Factor fw_cfg_init_mem_internal() out Philippe Mathieu-Daudé
2025-05-07 6:36 ` Zhao Liu
2025-05-02 18:56 ` [PATCH v3 05/19] hw/i386/x86: Remove X86MachineClass::fwcfg_dma_enabled field Philippe Mathieu-Daudé
2025-05-07 6:41 ` Zhao Liu
2025-05-02 18:56 ` [PATCH v3 06/19] hw/nvram/fw_cfg: Remove fw_cfg_io_properties::dma_enabled Philippe Mathieu-Daudé
2025-05-07 6:46 ` Zhao Liu
2025-05-02 18:56 ` [PATCH v3 07/19] hw/i386/pc: Remove pc_compat_2_6[] array Philippe Mathieu-Daudé
2025-05-07 6:47 ` Zhao Liu
2025-05-02 18:56 ` [PATCH v3 08/19] hw/intc/apic: Remove APICCommonState::legacy_instance_id field Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 09/19] hw/core/machine: Remove hw_compat_2_6[] array Philippe Mathieu-Daudé
2025-05-08 7:49 ` Thomas Huth
2025-05-02 18:56 ` [PATCH v3 10/19] hw/virtio/virtio-mmio: Remove VirtIOMMIOProxy::format_transport_address field Philippe Mathieu-Daudé
2025-05-08 7:51 ` Thomas Huth
2025-05-02 18:56 ` [PATCH v3 11/19] hw/i386/pc: Remove deprecated pc-q35-2.7 and pc-i440fx-2.7 machines Philippe Mathieu-Daudé
2025-05-05 9:50 ` Philippe Mathieu-Daudé
2025-05-08 7:53 ` Thomas Huth
2025-05-02 18:56 ` [PATCH v3 12/19] hw/i386/pc: Remove pc_compat_2_7[] array Philippe Mathieu-Daudé
2025-05-08 7:55 ` Thomas Huth
2025-05-08 10:40 ` Philippe Mathieu-Daudé
2025-05-08 11:41 ` Thomas Huth
2025-05-08 12:09 ` Zhao Liu
2025-05-02 18:56 ` [PATCH v3 13/19] hw/audio/pcspk: Remove PCSpkState::migrate field Philippe Mathieu-Daudé
2025-05-08 7:57 ` Thomas Huth
2025-05-02 18:56 ` [PATCH v3 14/19] hw/core/machine: Remove hw_compat_2_7[] array Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 15/19] hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 16/19] hw/intc/ioapic: Remove IOAPICCommonState::version field Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 17/19] hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 18/19] hw/char/virtio-serial: Do not expose the 'emergency-write' property Philippe Mathieu-Daudé
2025-05-02 18:56 ` [PATCH v3 19/19] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_PAGE_PER_VQ definition Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBr8Zknwle47ljOB@intel.com \
--to=zhao1.liu@intel.com \
--cc=amit@kernel.org \
--cc=anisinha@redhat.com \
--cc=chenhuacai@kernel.org \
--cc=clement.mathieu--drif@eviden.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.caveayland@nutanix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.