From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E079FC3ABBC for ; Wed, 7 May 2025 03:17:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uCVHf-00070X-HR; Tue, 06 May 2025 23:17:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCVHP-0006zF-Mv; Tue, 06 May 2025 23:17:08 -0400 Received: from mgamail.intel.com ([192.198.163.8]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCVHN-0004r5-VH; Tue, 06 May 2025 23:17:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746587826; x=1778123826; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=GK4VYR5LTeX5ux76u2PbXKsC5G2W9XPxyQK76/bgtpI=; b=ZMxsuYyEqnn9ajYxvG/T0G4p+ioi4WkU+sC6l06cTqvFlrOC93ka5Uyk c6Xb/eha5LgTVB4munpO5NEUUVnQ6vokEVHhU9HCR1iiIXpC+pDO4dMP3 pUcvnnj9la6grDIlS4WL0gMYNdgvHR4uFAvMkTHTkVbb6SCicx9MvLBDs /q18fl3DYhE4JLheGUCayl6T0yh2vp9ZbM4EeNDMz+DS3lkSXltRjux+c 7vDoIu7XNTuQEtJ/StSOdAbF8FWa+vKSg2K3xcrqPzpanJRDjx80CQ33Q na/ncqt8nM3/3Vr4CF8myCj30Keer6Y10RQlBcKYcnIWnvOSwUy/G9idw g==; X-CSE-ConnectionGUID: bJrdEeaqS3uvfLZtl0si8A== X-CSE-MsgGUID: Xn+OWCyJSNmyB/d/PZ0LWQ== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="65822487" X-IronPort-AV: E=Sophos;i="6.15,268,1739865600"; d="scan'208";a="65822487" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 20:17:04 -0700 X-CSE-ConnectionGUID: wnkF5hUwSlqiVaL0+7FK0A== X-CSE-MsgGUID: 6Xif0lYLT4qzFQ26iz8jiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,268,1739865600"; d="scan'208";a="135708511" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by orviesa006.jf.intel.com with ESMTP; 06 May 2025 20:16:59 -0700 Date: Wed, 7 May 2025 11:38:00 +0800 From: Zhao Liu To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Kevin Wolf , Yanan Wang , Paolo Bonzini , Eduardo Habkost , Fam Zheng , Hanna Reitz , qemu-block@nongnu.org, Dmitry Fleytman , Richard Henderson , Laurent Vivier , John Snow , Jason Wang , Marcel Apfelbaum , "Michael S. Tsirkin" , Gerd Hoffmann , Fabiano Rosas , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Thomas Huth Subject: Re: [PATCH v3 10/19] hw/i386/x86: Remove X86MachineClass::save_tsc_khz field Message-ID: References: <20250506143905.4961-1-philmd@linaro.org> <20250506143905.4961-11-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250506143905.4961-11-philmd@linaro.org> Received-SPF: pass client-ip=192.198.163.8; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -57 X-Spam_score: -5.8 X-Spam_bar: ----- X-Spam_report: (-5.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.414, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, May 06, 2025 at 04:38:56PM +0200, Philippe Mathieu-Daudé wrote: > Date: Tue, 6 May 2025 16:38:56 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v3 10/19] hw/i386/x86: Remove X86MachineClass::save_tsc_khz > field > X-Mailer: git-send-email 2.47.1 > > The X86MachineClass::save_tsc_khz boolean was only used > by the pc-q35-2.5 and pc-i440fx-2.5 machines, which got > removed. Remove it and simplify tsc_khz_needed(). > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Daniel P. Berrangé > Reviewed-by: Thomas Huth > --- > include/hw/i386/x86.h | 5 ----- > hw/i386/x86.c | 1 - > target/i386/machine.c | 5 ++--- > 3 files changed, 2 insertions(+), 9 deletions(-) Reviewed-by: Zhao Liu