All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Yosry Ahmed <yosry.ahmed@linux.dev>,
	Vitaly Wool <vitaly.wool@konsulko.se>,
	linux-mm@kvack.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, Nhat Pham <nphamcs@gmail.com>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Minchan Kim <minchan@kernel.org>,
	Igor Belousov <igor.b@beldev.am>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] mm/zblock: use vmalloc for page allocations
Date: Wed, 7 May 2025 10:50:18 +0200	[thread overview]
Message-ID: <aBseynlpPBIIvlPY@pc636> (raw)
In-Reply-To: <b42gpp5qsa4j22ai2v4rwwkjhvfbcbf3lcnjoccz7xeidae5c7@ot2ocric3qzs>

On Wed, May 07, 2025 at 03:08:08PM +0900, Sergey Senozhatsky wrote:
> On (25/05/07 14:57), Sergey Senozhatsky wrote:
> > On (25/05/06 13:13), Yosry Ahmed wrote:
> > > If we can use vmalloc for zblock, then we can probably also use vmalloc
> > > in zsmalloc and get rid of the chaining logic completely. This would
> > > make zsmalloc simpler and closer to zblock in that regard.
> > > 
> > > Sergey, WDYT?
> > 
> > This sounds interesting.  We might get rid of lots of memcpy()
> > in object read/write paths, and so on.  I don't know if 0-order
> > chaining was the only option for zsmalloc, or just happened to
> > be the first one.
> 
> I assume we might have problems with zspage release path.  vfree()
> should break .swap_slot_free_notify, as far as I can see.
> .swap_slot_free_notify is called under swap-cluster spin-lock,
> so if we free the last object in the zspage we cannot immediately
> free that zspage, because vfree() might_sleep().
> 
you can use vfree_atomic(), it can be collected in any atomic but
no in NMI.

--
Uladzislau Rezki


  parent reply	other threads:[~2025-05-07  8:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02  8:01 [PATCH] mm/zblock: use vmalloc for page allocations Vitaly Wool
2025-05-02  8:07 ` Igor Belousov
2025-05-03 18:46   ` Vitaly Wool
2025-05-04  5:02     ` Sergey Senozhatsky
2025-05-04  6:14       ` Sergey Senozhatsky
2025-05-05 14:08     ` Johannes Weiner
2025-05-06  2:13       ` Sergey Senozhatsky
2025-05-05 14:29 ` Johannes Weiner
2025-05-06  9:42   ` Uladzislau Rezki
2025-05-05 16:20 ` kernel test robot
2025-05-05 22:08 ` kernel test robot
2025-05-06 13:13 ` Yosry Ahmed
2025-05-06 13:27   ` Herbert Xu
2025-05-06 13:37     ` Christoph Hellwig
2025-05-07  5:57   ` Sergey Senozhatsky
2025-05-07  6:08     ` Sergey Senozhatsky
2025-05-07  6:14       ` Sergey Senozhatsky
2025-05-07  6:54       ` Christoph Hellwig
2025-05-08  5:58         ` Sergey Senozhatsky
2025-05-08  6:00           ` Christoph Hellwig
2025-05-08  6:17             ` Sergey Senozhatsky
2025-05-08  6:33               ` Sergey Senozhatsky
2025-05-07  8:50       ` Uladzislau Rezki [this message]
2025-05-08  6:07         ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBseynlpPBIIvlPY@pc636 \
    --to=urezki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=igor.b@beldev.am \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=nphamcs@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=shakeel.butt@linux.dev \
    --cc=vitaly.wool@konsulko.se \
    --cc=yosry.ahmed@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.