Re: [PATCH v5 1/5] cgroup: use helper for distingushing css in callbacks

[Yosry Ahmed <yosry.ahmed@linux.dev>]

On Fri, May 02, 2025 at 05:12:18PM -0700, JP Kobryn wrote:
> The callbacks used for cleaning up css's check whether the css is
> associated with a subsystem or not. Instead of just checking the ss
> pointer, use the helper functions to better show the intention.
> 
> Signed-off-by: JP Kobryn <inwardvessel@gmail.com>

I still think this should be renamed and potentially reimplemented to
(also?) check css->cgroup->self, but anyway:

Reviewed-by: Yosry Ahmed <yosry.ahmed@linux.dev>

> ---
>  kernel/cgroup/cgroup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 7471811a00de..125240f8318c 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -5406,7 +5406,7 @@ static void css_free_rwork_fn(struct work_struct *work)
>  
>  	percpu_ref_exit(&css->refcnt);
>  
> -	if (ss) {
> +	if (!css_is_cgroup(css)) {
>  		/* css free path */
>  		struct cgroup_subsys_state *parent = css->parent;
>  		int id = css->id;
> @@ -5460,7 +5460,7 @@ static void css_release_work_fn(struct work_struct *work)
>  	css->flags |= CSS_RELEASED;
>  	list_del_rcu(&css->sibling);
>  
> -	if (ss) {
> +	if (!css_is_cgroup(css)) {
>  		struct cgroup *parent_cgrp;
>  
>  		/* css release path */
> -- 
> 2.47.1
> 
>