All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrique Carvalho <henrique.carvalho@suse.com>
To: Steve French <smfrench@gmail.com>
Cc: Enzo Matsumiya <ematsumiya@suse.de>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Bharath S M <bharathsm@microsoft.com>,
	ronnie sahlberg <ronniesahlberg@gmail.com>,
	CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] smb: client: avoid dentry leak by not overwriting cfid->dentry
Date: Wed, 7 May 2025 16:38:27 -0300	[thread overview]
Message-ID: <aBu2swvrsvhnle2n@precision> (raw)
In-Reply-To: <CAH2r5msisxGqZCFpJUu1Bqv5Kgo+-HD2DEO+wzQeSqG6TS2J6Q@mail.gmail.com>

On Wed, May 07, 2025 at 02:01:08PM -0500, Steve French wrote:
> 
>    With both patches I still see the hang in generic/013 to azure
>    multichannel but it does still fix the directory lease crash
> 
>    [1]http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/buil
>    ders/5/builds/444

I cannot see the mount options for this test, does it mount with
nohandlecache?

> 
>    Thanks,
> 
>    Steve
> 
>    On Wed, May 7, 2025, 11:31 AM Steve French <[2]smfrench@gmail.com>
>    wrote:
> 
>    I can try some test runs with Paul's patch.   I wasn't clear on whether
>    it obsoletes Henrique's patch or if both would still be needed though.
>    Is it ok to run with both patches

I believe Paul's patch makes mine obsolete, unless I'm missing something
-- or unless we want to be extra cautious by keeping the dentry check as
an additional safeguard.


  parent reply	other threads:[~2025-05-07 19:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 22:31 [PATCH] smb: client: avoid dentry leak by not overwriting cfid->dentry Henrique Carvalho
2025-05-07  6:16 ` Paul Aurich
2025-05-07 14:03   ` Henrique Carvalho
     [not found]   ` <CAH2r5muyz7zY=+Fgrtc_zOA6GR1ZSGpR-Z4pFzgqmfszhnywWQ@mail.gmail.com>
2025-05-07 17:01     ` Fwd: " Steve French
     [not found]     ` <CAH2r5msisxGqZCFpJUu1Bqv5Kgo+-HD2DEO+wzQeSqG6TS2J6Q@mail.gmail.com>
2025-05-07 19:38       ` Henrique Carvalho [this message]
2025-05-07 23:56   ` Steve French
2025-05-08 15:24   ` Shyam Prasad N
2025-05-08 15:53     ` Paul Aurich
2025-05-08 16:09       ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBu2swvrsvhnle2n@precision \
    --to=henrique.carvalho@suse.com \
    --cc=bharathsm@microsoft.com \
    --cc=ematsumiya@suse.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.