All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests/shell: Skip netdev_chain_dev_addremove on tainted kernels
Date: Thu, 8 May 2025 13:15:33 +0200	[thread overview]
Message-ID: <aBySVYDLHjnqC8TF@calendula> (raw)
In-Reply-To: <20250508102654.17077-1-phil@nwl.cc>

On Thu, May 08, 2025 at 12:26:54PM +0200, Phil Sutter wrote:
> The test checks taint state to indicate success or failure. Since this
> won't work if the kernel is already tainted at start, skip the test
> instead of failing it.
> 
> Fixes: 02dbf86f39410 ("tests: shell: add a test case for netdev ruleset flush + parallel link down")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>

Thanks, Florian made similar patch quite recently for selftests.

  reply	other threads:[~2025-05-08 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 10:26 [nft PATCH] tests/shell: Skip netdev_chain_dev_addremove on tainted kernels Phil Sutter
2025-05-08 11:15 ` Pablo Neira Ayuso [this message]
2025-05-08 21:50 ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBySVYDLHjnqC8TF@calendula \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.