From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: peda@axentia.se, broonie@kernel.org, andersson@kernel.org,
krzk+dt@kernel.org, ivprusov@salutedevices.com,
luca.ceresoli@bootlin.com, zhoubinbin@loongson.cn,
paulha@opensource.cirrus.com, lgirdwood@gmail.com,
robh@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org,
perex@perex.cz, tiwai@suse.com,
dmitry.baryshkov@oss.qualcomm.com, linux-sound@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, johan+linaro@kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Christopher Obbard <christopher.obbard@linaro.org>,
srinivas.kandagatla@linaro.org
Subject: Re: [PATCH v6 6/6] arm64: dts: qcom: x1e78100-t14s: Enable audio headset support
Date: Thu, 8 May 2025 14:47:18 +0200 [thread overview]
Message-ID: <aByn1mnsClCquBSh@hovoldconsulting.com> (raw)
In-Reply-To: <Z-zweM9llVE-bzYc@hovoldconsulting.com>
Hi Bjorn,
On Wed, Apr 02, 2025 at 10:08:24AM +0200, Johan Hovold wrote:
> On Thu, Mar 27, 2025 at 10:06:33AM +0000, Srinivas Kandagatla wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >
> > On Lenovo ThinkPad T14s, the headset is connected via a HiFi mux to
> > support CTIA and OMTP headsets. This switch is used to minimise pop and
> > click during headset type switching.
> >
> > Enable the mux controls required to power this switch along with wiring up
> > gpio that control the headset switching.
> >
> > Without this, headset audio will be very noisy and might see headset
> > detection errors.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Tested-by: Christopher Obbard <christopher.obbard@linaro.org>
>
> Looks good and both playback and recording works fine:
>
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
> Tested-by: Johan Hovold <johan+linaro@kernel.org>
Assuming the mux change will make it into 6.16 now, can you pick this
one up as well?
Johan
next prev parent reply other threads:[~2025-05-08 12:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 10:06 [PATCH v6 0/6] ASoC: wcd938x: enable t14s audio headset srinivas.kandagatla
2025-03-27 10:06 ` [PATCH v6 1/6] dt-bindings: mux: add optional regulator binding to gpio mux srinivas.kandagatla
2025-05-08 12:57 ` (subset) " Krzysztof Kozlowski
2025-03-27 10:06 ` [PATCH v6 2/6] mux: gpio: add optional regulator support srinivas.kandagatla
2025-04-01 10:16 ` Mark Brown
2025-04-02 8:11 ` Srinivas Kandagatla
2025-04-02 8:05 ` Johan Hovold
2025-05-08 12:45 ` Johan Hovold
2025-05-08 12:54 ` Krzysztof Kozlowski
2025-05-08 12:57 ` (subset) " Krzysztof Kozlowski
2025-03-27 10:06 ` [PATCH v6 3/6] ASoC: codecs: wcd-mbhc: cleanup swap_gnd_mic api srinivas.kandagatla
2025-03-27 12:11 ` Dmitry Baryshkov
2025-03-27 10:06 ` [PATCH v6 4/6] ASoC: dt-bindings: wcd93xx: add bindings for audio mux controlling hp srinivas.kandagatla
2025-03-27 10:06 ` [PATCH v6 5/6] ASoC: codecs: wcd938x: add mux control support for hp audio mux srinivas.kandagatla
2025-03-27 12:13 ` Dmitry Baryshkov
2025-04-02 8:06 ` Johan Hovold
2025-04-02 9:12 ` Johan Hovold
2025-04-03 12:19 ` Srinivas Kandagatla
2025-04-03 14:29 ` Johan Hovold
2025-04-05 17:27 ` Dmitry Baryshkov
2025-03-27 10:06 ` [PATCH v6 6/6] arm64: dts: qcom: x1e78100-t14s: Enable audio headset support srinivas.kandagatla
2025-04-02 8:08 ` Johan Hovold
2025-05-08 12:47 ` Johan Hovold [this message]
2025-05-08 12:55 ` Krzysztof Kozlowski
2025-05-17 5:57 ` (subset) " Bjorn Andersson
2025-04-08 12:49 ` (subset) [PATCH v6 0/6] ASoC: wcd938x: enable t14s audio headset Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aByn1mnsClCquBSh@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=christopher.obbard@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ivprusov@salutedevices.com \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=paulha@opensource.cirrus.com \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.