From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] tests/functional: Use -no-shutdown in the hppa_seabios test
Date: Thu, 8 May 2025 19:22:15 +0100 [thread overview]
Message-ID: <aBz2V2NKMjvJfqzY@redhat.com> (raw)
In-Reply-To: <20250508180918.228757-1-thuth@redhat.com>
On Thu, May 08, 2025 at 08:09:18PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> qemu-system-hppa shuts down automatically when the BIOS is
> unable to boot from any device. So this test currently fails
> occasionally when QEMU already quit, but the test still
> expected it to be around (e.g. to shut it down cleanly).
> Adding a "-no-shutdown" seems to make it reliable.
> While we're at it, also remove the stray "self.machine" in
> there that does not have any purpose.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/test_hppa_seabios.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-05-08 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 18:09 [PATCH] tests/functional: Use -no-shutdown in the hppa_seabios test Thomas Huth
2025-05-08 18:22 ` Daniel P. Berrangé [this message]
2025-05-09 8:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBz2V2NKMjvJfqzY@redhat.com \
--to=berrange@redhat.com \
--cc=deller@gmx.de \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.