From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81A83C3DA6D for ; Tue, 20 May 2025 22:39:10 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.991212.1375095 (Exim 4.92) (envelope-from ) id 1uHVbi-0004nK-Ts; Tue, 20 May 2025 22:38:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 991212.1375095; Tue, 20 May 2025 22:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uHVbi-0004nD-RF; Tue, 20 May 2025 22:38:46 +0000 Received: by outflank-mailman (input) for mailman id 991212; Tue, 20 May 2025 22:38:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uHVbf-0004n7-Io for xen-devel@lists.xenproject.org; Tue, 20 May 2025 22:38:44 +0000 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d76d4fa-35cb-11f0-b892-0df219b8e170; Wed, 21 May 2025 00:38:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d76d4fa-35cb-11f0-b892-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=3kmeimwcg5anvaqtqopafa2g7m.protonmail; t=1747780719; x=1748039919; bh=GU7U0HUUmE7hVz7GtWdDUkNOfae/4u4CfAELipLpg6g=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=BrWI86SSdC8RToSSBbzD6TYfQIsptKaCWjHF90UErC4DPH0oz4ydzshAMt2ZOktkZ k82Rfjowmjnv4IZ2Q9p3//veRaQLzuEDnXH159J92UFJHvz4jtM16vDJ+CrCSeXjPT tDkKGYU0Km/JSvgjzIIS5/rFnDn0TFYZdV6M+bjl0rGqx8h65WhDoX1ntOUDbRQ6E1 a8KMIx52WHgd2gaMUhdgCXw/xD3TiS1rSwew+dqrZeKX53ehtQ8tQIIRGhWO0IPOWE /SfdbM4hOQ9vbGExonFbq6NR/4wpkz+FxA8biMsh6A8xY6t+RPgTKV3xD/QDRf/EY9 aREEdzdgwDFbA== Date: Tue, 20 May 2025 22:38:33 +0000 To: Jan Beulich From: dmkhn@proton.me Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok() Message-ID: In-Reply-To: References: <20250516022855.1146121-1-dmukhin@ford.com> <20250516022855.1146121-3-dmukhin@ford.com> Feedback-ID: 123220910:user:proton X-Pm-Message-ID: a0d1c2ca659a8b1d3d2a721ea0cb77cbfee0524e MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, May 20, 2025 at 05:24:33PM +0200, Jan Beulich wrote: > On 16.05.2025 04:29, dmkhn@proton.me wrote: > > --- a/xen/arch/x86/include/asm/domain.h > > +++ b/xen/arch/x86/include/asm/domain.h > > @@ -494,6 +494,12 @@ struct arch_domain > > X86_EMU_PIT | X86_EMU_USE_PIRQ | = \ > > X86_EMU_VPCI) > > > > +/* User-selectable features. */ > > +#define X86_EMU_OPTIONAL (X86_EMU_USE_PIRQ) > > + > > +#define X86_EMU_BASELINE (X86_EMU_ALL & ~(X86_EMU_VPCI | \ > > + X86_EMU_OPTIONAL)) >=20 > That is, VPCI is neither baseline nor optional. Certainly at least strang= e. IMO, X86_EMU_OPTIONAL should include both VPCI and PIRQ. But that will be a behavior change: AFAIU, VPCI is injected implicitly for = dom0 case only, "default" xl toolstack currently excludes VPCI for HVM domains. Do I understand it correctly that "BASELINE" in the symbol name is a concer= n? >=20 > Jan