Re: [PATCH master] of: partition: overwrite arm,arm-firmware-suite unless donttouch

[Robert Schwebel <r.schwebel@pengutronix.de>]

On Tue, May 20, 2025 at 02:41:18PM +0200, Ahmad Fatoum wrote:
> barebox doesn't support arm,arm-firmware-suite partitioning and if the
> barebox device tree uses a fixed-partitions binding for a flash, it will
> overwrite a kernel partitions node that uses arm,arm-firmware-suite with
> the fixed partition binding.
> 
> This broke in the default case with the addition of
> global.of_partition_binding=adaptive, because the check for a compatible
> was successful, but the compatible was neither fixed-partitions or
> barebox,fixed-partitions.
> 
> Fix this by explicitly checking the compatibles we expect.
> This fixes a failed of_get_reproducible_name in of_state_fixup, which
> broke barebox-state usage on Vexpress in DistroKit.
> 
> Fixes: f0d91d7ba6cb ("of: partition: add Linux CONFIG_OF_PARTITION-compatible adaptive fixup mode")
> Reported-by: Robert Schwebel <rsc@pengutronix.de>

Thanks, works for me.

rsc

> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |