From: Oscar Salvador <osalvador@suse.de>
To: Mike Rapoport <rppt@kernel.org>
Cc: Changyuan Lyu <changyuanl@google.com>,
akpm@linux-foundation.org, bhe@redhat.com, chrisl@kernel.org,
graf@amazon.com, jasonmiu@google.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
pasha.tatashin@soleen.com
Subject: Re: [PATCH 1/2] memblock: show a warning if allocation in KHO scratch fails
Date: Wed, 21 May 2025 10:48:55 +0200 [thread overview]
Message-ID: <aC2TdzP1AwYrQdcW@localhost.localdomain> (raw)
In-Reply-To: <aC2EE1pg9ktQdstI@kernel.org>
On Wed, May 21, 2025 at 10:43:15AM +0300, Mike Rapoport wrote:
> I think we should just make sparse_init_nid() panic or at least change
> "sparse_init_nid: node[0] memory map backing failed. Some memory will not be available."
> to something more visible and clear.
Panicking the system seems a bit too harsh.
Those sections will not be initialized, and sure you will lose some memory,
but still.
I think that making sure that subsection_map_init() does not access
non-initialized values is enough.
Because wrt. error message, I am not sure it can get more clear that we
failed we allocate memory to back the section and so that section will
not be activated :-)
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-05-21 8:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-18 14:23 [PATCH 0/2] KHO Fixes Changyuan Lyu
2025-05-18 14:23 ` [PATCH 1/2] memblock: show a warning if allocation in KHO scratch fails Changyuan Lyu
2025-05-18 16:07 ` Mike Rapoport
2025-05-21 7:03 ` Changyuan Lyu
2025-05-21 7:43 ` Mike Rapoport
2025-05-21 8:48 ` Oscar Salvador [this message]
2025-05-21 15:27 ` Mike Rapoport
2025-05-18 14:23 ` [PATCH 2/2] KHO: init new_physxa->phys_bits to fix lockdep Changyuan Lyu
2025-05-18 15:51 ` Mike Rapoport
2025-05-19 12:10 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC2TdzP1AwYrQdcW@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=changyuanl@google.com \
--cc=chrisl@kernel.org \
--cc=graf@amazon.com \
--cc=jasonmiu@google.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.