From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Polensky <japo@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH v1 1/2] safe_macros.c: Fix missing ro flag for FUSE NTFS mounts
Date: Wed, 21 May 2025 11:37:31 +0200 [thread overview]
Message-ID: <aC2e24S2FzFRM5-N@rei> (raw)
In-Reply-To: <20250513165640.185122-2-japo@linux.ibm.com>
Hi!
> diff --git a/lib/safe_macros.c b/lib/safe_macros.c
> index 6946cc5bcb94..1270b17af8f4 100644
> --- a/lib/safe_macros.c
> +++ b/lib/safe_macros.c
> @@ -942,10 +942,15 @@ int safe_mount(const char *file, const int lineno, void (*cleanup_fn)(void),
> */
> if (possibly_fuse(filesystemtype)) {
> char buf[1024];
> + const char* mount_fmt;
>
> tst_resm_(file, lineno, TINFO, "Trying FUSE...");
> - snprintf(buf, sizeof(buf), "mount.%s '%s' '%s'",
> - filesystemtype, source, target);
> + if (!strcmp(filesystemtype, "ntfs") && mountflags & MS_RDONLY)
Do we need to limit this to "ntfs"? I suppose that for other FUSE
filesystems would have the same problem, e.g. exfat.
Other than this the patch looks good.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-21 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 16:56 [LTP] [RFC PATCH v1 0/2] Fix NTFS-related failures in statmount02 and Jan Polensky
2025-05-13 16:56 ` [LTP] [RFC PATCH v1 1/2] safe_macros.c: Fix missing ro flag for FUSE NTFS mounts Jan Polensky
2025-05-15 19:48 ` Petr Vorel
2025-05-16 6:26 ` Li Wang via ltp
2025-05-21 9:37 ` Cyril Hrubis [this message]
2025-05-21 9:55 ` Cyril Hrubis
2025-06-04 11:59 ` Cyril Hrubis
2025-05-13 16:56 ` [LTP] [RFC PATCH v1 2/2] statmount06.c: Fix incorrect fs_type assumption NTFS->FUSEBLK Jan Polensky
2025-05-21 9:45 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC2e24S2FzFRM5-N@rei \
--to=chrubis@suse.cz \
--cc=japo@linux.ibm.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.