From: Tejun Heo <tj@kernel.org>
To: "Shashank.Mahadasyam@sony.com" <Shashank.Mahadasyam@sony.com>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Shinya.Takumi@sony.com" <Shinya.Takumi@sony.com>
Subject: Re: [PATCH v2 1/3] cgroup, docs: be specific about bandwidth control of rt processes
Date: Wed, 21 May 2025 06:30:18 -1000 [thread overview]
Message-ID: <aC3_moeLiTc4x85y@slm.duckdns.org> (raw)
In-Reply-To: <OSZPR01MB67115CCC104221C27EE63709939EA@OSZPR01MB6711.jpnprd01.prod.outlook.com>
Hello,
On Wed, May 21, 2025 at 01:14:53AM +0000, Shashank.Mahadasyam@sony.com wrote:
> Hi Tejun,
>
> On 21 May 2025 5:11, Tejun Heo wrote:
> > > -WARNING: cgroup2 cpu controller doesn't yet fully support the control of
> > > +WARNING: cgroup2 cpu controller doesn't yet support the (bandwidth) control of
> >
> > This reads weird to me. Without the () part, it becomes "doesn't yet support
> > the control of". Maybe rephrase it a bit more?
>
> I'm not sure how to rephrase it. It sounds fine to me 😅 Moreover, "doesn't
> yet support the control of" was the wording when the warning paragraph on
> RT_GROUP_SCHED was added in commit c2f31b79 (cgroup: add warning about RT
> not being supported on cgroup2). Would removing the parentheses, making it
> "doesn't yet support the bandwidth control of", sound better?
You're right. I was thinking about sched_ext not RT. Lemme apply the patch
as-is.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-05-21 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 14:07 [PATCH v2 0/3] cgroup, docs: cpu controller interaction with various scheduling policies Shashank Balaji
2025-05-20 14:07 ` Shashank Balaji via B4 Relay
2025-05-20 14:07 ` [PATCH v2 1/3] cgroup, docs: be specific about bandwidth control of rt processes Shashank Balaji
2025-05-20 14:07 ` Shashank Balaji via B4 Relay
2025-05-20 20:11 ` Tejun Heo
2025-05-21 1:14 ` Shashank.Mahadasyam
2025-05-21 16:30 ` Tejun Heo [this message]
2025-05-21 16:35 ` Tejun Heo
2025-05-20 14:07 ` [PATCH v2 2/3] sched_ext, docs: add label Shashank Balaji
2025-05-20 14:07 ` Shashank Balaji via B4 Relay
2025-05-20 20:26 ` Tejun Heo
2025-05-20 14:07 ` [PATCH v2 3/3] cgroup, docs: cpu controller interaction with various scheduling policies Shashank Balaji
2025-05-20 14:07 ` Shashank Balaji via B4 Relay
2025-05-20 20:16 ` Tejun Heo
2025-05-21 7:49 ` Shashank Balaji
2025-05-21 17:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC3_moeLiTc4x85y@slm.duckdns.org \
--to=tj@kernel.org \
--cc=Shashank.Mahadasyam@sony.com \
--cc=Shinya.Takumi@sony.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.