Re: [OFFLIST PATCH 2/2] cgroup: use subsystem-specific rstat locks to avoid contention

[Tejun Heo <tj@kernel.org>]

On Thu, May 22, 2025 at 12:23:44AM +0200, Klara Modin wrote:
> Hi,
> 
> On 2025-04-28 23:15:58 -0700, Shakeel Butt wrote:
> > Please ignore this patch as it was sent by mistake.
> 
> This seems to have made it into next:
> 
> 748922dcfabd ("cgroup: use subsystem-specific rstat locks to avoid contention")
> 
> It causes a BUG and eventually a panic on my Raspberry Pi 1:
> 
> WARNING: CPU: 0 PID: 0 at mm/percpu.c:1766 pcpu_alloc_noprof (mm/percpu.c:1766 (discriminator 2)) 
> illegal size (0) or align (4) for percpu allocation
> CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.15.0-rc7-next-20250521-00086-ga9fb18e56aad #263 NONE
> Hardware name: BCM2835
> Call trace:
> unwind_backtrace from show_stack (arch/arm/kernel/traps.c:259) 
> show_stack from dump_stack_lvl (lib/dump_stack.c:122) 
> dump_stack_lvl from __warn (kernel/panic.c:729 kernel/panic.c:784) 
> __warn from warn_slowpath_fmt (kernel/panic.c:815) 
> warn_slowpath_fmt from pcpu_alloc_noprof (mm/percpu.c:1766 (discriminator 2)) 
> pcpu_alloc_noprof from ss_rstat_init (kernel/cgroup/rstat.c:515) 
> ss_rstat_init from cgroup_init_subsys (kernel/cgroup/cgroup.c:6134 (discriminator 2)) 
> cgroup_init_subsys from cgroup_init (kernel/cgroup/cgroup.c:6240) 
> cgroup_init from start_kernel (init/main.c:1093) 
>  start_kernel from 0x0
> ...
> kernel BUG at kernel/cgroup/cgroup.c:6134!
> Internal error: Oops - BUG: 0 [#1] ARM
> 
> Reverting resolved it for me.

This posting was a mistake but direct postings from JP weren't. This being
pretty close to the merge window, unless the problem is trivial, the right
thing to do probalby is reverting the series. JP, what do you think?

Thanks.

-- 
tejun