Re: [PATCH v5 3/4] drivers/base/node: Remove register_memory_blocks_under_node() function call from register_one_node

[Mike Rapoport <rppt@kernel.org>]

On Thu, May 22, 2025 at 12:06:06PM +0200, Oscar Salvador wrote:
> On Thu, May 22, 2025 at 04:17:30AM -0500, Donet Tom wrote:
> > diff --git a/include/linux/node.h b/include/linux/node.h
> > index 5c763253c42c..6cf349c26780 100644
> > --- a/include/linux/node.h
> > +++ b/include/linux/node.h
> > @@ -136,18 +136,8 @@ static inline int register_one_node(int nid)
> >  {
> >  	int error = 0;
> >  
> > -	if (node_online(nid)) {
> > -		struct pglist_data *pgdat = NODE_DATA(nid);
> > -		unsigned long start_pfn = pgdat->node_start_pfn;
> > -		unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages;
> > -
> > +	if (node_online(nid))
> >  		error = __register_one_node(nid);
> 
> Heh, remembering this code always brings me joy.
> 
> After this patch, register_one_node() is only called from try_online_node(), right?
> Which, before calling in, explicitly sets the node online, so... we can get rid of
> the node_online() check unless I am missing something.
 
I think you are right and a sensible follow up cleanup can be renaming
__register_one_node() to register_one_node() :)
 
> -- 
> Oscar Salvador
> SUSE Labs
> 

-- 
Sincerely yours,
Mike.