From: Oscar Salvador <osalvador@suse.de>
To: Ge Yang <yangge1116@126.com>
Cc: Muchun Song <muchun.song@linux.dev>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
21cnbao@gmail.com, david@redhat.com,
baolin.wang@linux.alibaba.com, liuzixing@hygon.cn
Subject: Re: [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when replacing free hugetlb folios
Date: Thu, 22 May 2025 13:49:26 +0200 [thread overview]
Message-ID: <aC8PRkyd3y74Ph5R@localhost.localdomain> (raw)
In-Reply-To: <ff6bd560-d249-418f-81f4-7cbe055a25ec@126.com>
On Thu, May 22, 2025 at 07:34:56PM +0800, Ge Yang wrote:
> It seems that we cannot simply remove the folio_test_hugetlb() check. The
> reasons are as follows:
Yeah, my thought was whether we could move the folio_hstate within
alloc_and_dissolve_hugetlb_folio(), since the latter really needs to take the
lock.
But isolate_or_dissolve_huge_page() also needs the 'hstate' not only to
pass it onto alloc_and_dissolve_hugetlb_folio() but to check whether
hstate is gigantic.
Umh, kinda hate sparkling the locks all around.
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-05-22 11:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 3:22 [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when replacing free hugetlb folios yangge1116
2025-05-22 3:47 ` Muchun Song
2025-05-22 5:34 ` Oscar Salvador
2025-05-22 7:13 ` Muchun Song
2025-05-22 10:13 ` Oscar Salvador
2025-05-22 11:34 ` Ge Yang
2025-05-22 11:49 ` Oscar Salvador [this message]
2025-05-22 12:39 ` Muchun Song
2025-05-22 19:32 ` Oscar Salvador
2025-05-23 3:27 ` Muchun Song
2025-05-23 3:46 ` Ge Yang
2025-05-23 3:56 ` Muchun Song
2025-05-23 5:30 ` Oscar Salvador
2025-05-23 8:07 ` Ge Yang
2025-05-22 11:50 ` Oscar Salvador
2025-05-26 12:41 ` David Hildenbrand
2025-05-26 12:57 ` Ge Yang
2025-05-26 12:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC8PRkyd3y74Ph5R@localhost.localdomain \
--to=osalvador@suse.de \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzixing@hygon.cn \
--cc=muchun.song@linux.dev \
--cc=stable@vger.kernel.org \
--cc=yangge1116@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.