From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 0/4] Continue upon netlink deserialization failures
Date: Thu, 22 May 2025 19:18:14 +0200 [thread overview]
Message-ID: <aC9cVrmOpQKNs1MW@calendula> (raw)
In-Reply-To: <20250521131242.2330-1-phil@nwl.cc>
On Wed, May 21, 2025 at 03:12:38PM +0200, Phil Sutter wrote:
> Faced with unexpected values or missing attributes, most of the netlink
> deserialization code would complain, drop the nftables object being
> constructed and carry on. Some error paths though instead call BUG() or
> assert(0) instead. This series eliminates at least the most prominent
> ones among those (patches 1 and 3).
>
> Patch 4 prevents object deserialization from aborting upon the first one
> with unexpected data. If netlink_delinearize_obj() returns NULL, an
> error message has been emitted already so just return 0 to the foreach
> loop so it continues with the next object.
>
> Patch 2 is just preparation work for patch 3.
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
next prev parent reply other threads:[~2025-05-22 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 13:12 [nft PATCH 0/4] Continue upon netlink deserialization failures Phil Sutter
2025-05-21 13:12 ` [nft PATCH 1/4] netlink_delinearize: Replace some BUG()s by error messages Phil Sutter
2025-05-21 13:12 ` [nft PATCH 2/4] netlink: Pass netlink_ctx to netlink_delinearize_setelem() Phil Sutter
2025-05-21 13:12 ` [nft PATCH 3/4] netlink: Keep going after set element parsing failures Phil Sutter
2025-05-21 14:17 ` Pablo Neira Ayuso
2025-05-21 17:19 ` Phil Sutter
2025-05-22 17:17 ` Pablo Neira Ayuso
2025-05-21 13:12 ` [nft PATCH 4/4] cache: Tolerate object deserialization failures Phil Sutter
2025-05-22 17:18 ` Pablo Neira Ayuso [this message]
2025-05-25 7:58 ` [nft PATCH 0/4] Continue upon netlink " Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC9cVrmOpQKNs1MW@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.