From: Anthony Iliopoulos <ailiop@suse.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/008: fix golden output for 512 fsblock size
Date: Sun, 11 May 2025 21:01:58 +0200 [thread overview]
Message-ID: <aCD0Jmx_V5bS3klb@technoir> (raw)
In-Reply-To: <20250511142954.swhxnifhxvvkg3ty@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Sun, May 11, 2025 at 10:29:54PM +0800, Zorro Lang wrote:
> On Thu, May 08, 2025 at 09:41:02AM +0200, Anthony Iliopoulos wrote:
> > commit 97989c9839dd ("xfs/008: use block size instead of the pagesize")
> > changed the test filter, which causes nocrc/512b fsblock configurations
> > to fail due to mismatch of the golden output. Update it to match the
> > expected output.
> >
> > Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> > ---
> > tests/xfs/008.out | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/xfs/008.out b/tests/xfs/008.out
> > index 0941e218c7d0..dc999156dab5 100644
> > --- a/tests/xfs/008.out
> > +++ b/tests/xfs/008.out
> > @@ -8,7 +8,7 @@ randholes.2 : -l FSIZE -c 100 -b BLKSIZE
> > ------------------------------------------
> > holes is in range
> >
> > -randholes.3 : -l FSIZE -c 100 -b 512
> > +randholes.3 : -l FSIZE -c 100 -b BLKSIZE
>
> This change fix the failure on nocrc/512b fsblock, but it causes xfs/008
> fail on all other blocksize xfs.
Indeed, thanks for catching this, I'll send a v2 with the corresponding
filter fix.
Regards,
Anthony
prev parent reply other threads:[~2025-05-11 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 7:41 [PATCH] xfs/008: fix golden output for 512 fsblock size Anthony Iliopoulos
2025-05-08 15:12 ` Darrick J. Wong
2025-05-11 14:29 ` Zorro Lang
2025-05-11 19:01 ` Anthony Iliopoulos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCD0Jmx_V5bS3klb@technoir \
--to=ailiop@suse.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.