Re: [PATCH v2] ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, May 12, 2025 at 04:18:22PM +0800, Shenghao Ding wrote:
> After commit 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c
> and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c,
> tasdevice_remove used for not only for I2C but for SPI being still in
> that lib caused ld issue.

> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://urldefense.com/v3/__https://lore.kernel.org/
> |  oe-kbuild-all/202505111855.FP2fScKA-lkp@intel.com/
> |  __;!!G3vK!U-wdsvrOG1iezggZ55RYi8ikBxMaJDVs7u17Z9-7Xa-
> |  0lnyE4S3m2qmLCcHVK4qH1bD1JuBdzg$

This should be in a tag area below, each tag is exactly one line (the same way
as Fixes:, for example)

> All errors (new ones prefixed by >>):
> >> ld.lld: error: undefined symbol: tasdevice_remove
>    >>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33)
>    >>>               vmlinux.o:(tas2781_hda_remove)
> To fix this issue, the implementation of tasdevice_remove was moved from
> tas2781-comlib-i2c.c to tas2781-comlib.c.

-- 
With Best Regards,
Andy Shevchenko