From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CD07610D; Mon, 12 May 2025 07:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747034469; cv=none; b=JqoJUz1TGdMBEifxkjxQw4mBC1SKW3MyquyUWRm+feAQwfSM3cpNBI8Xy8Td5cI04QJJ9ORjZindxq+MGpHVZXQ7BWvPVXnJCpgWnAldGlBxKshc+8/LSTagfEa+gQq4hGR15cbOPblepe5EcDG8ivloFGIH17lk4xiikFEFX9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747034469; c=relaxed/simple; bh=eF0FqKnVhO8GoltT+ZFMvKgjKuVLYtXTdM20AOWMwyY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qJC0+M/B/iahrD4xIYEBXHiqohKoCnyEvM6CdWxxo+3hUyOI2IgynBlzirZ8BumRchq1IwdFzudO+Je7/PUGPyvA+McHyI2ooAsiJiY/bu5DfHF6O164bwDUNMLMwtUajYWcM7QiS2+Mt3xKPRpRfEejUDyqTsmOFzWxPGYOHcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XU/tH/h9; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XU/tH/h9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747034467; x=1778570467; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=eF0FqKnVhO8GoltT+ZFMvKgjKuVLYtXTdM20AOWMwyY=; b=XU/tH/h9xalOruc+hf2frwIt60WCPwW3kLIUdwD1MsskIAaaOUWzBwju CmNEFwRHPSV1fp+DCos4vXP4jSkHXPUQk0xkRge6vJdzrwRWx3tWRDiv4 3uiFuf5DYYy1nru1tSVqHOAiAv4ossjPy9J9UNPjyjAyYMoaM0fYUn3fB Nd5jRiBv88pNw5HnT2w2UayhoaE6kR63LApSIf99zBqghUtluamMg0Rem HeV3CbVBvkRSsGZYMcsUJhjuHcBhAP6Df9puiljHYoX4chdZwhq7ZhSXx Uiz39HKHqzoZmVVkTbBqAh8r1FMA30ad8ODDfVtKXQjS3P3qyG4Hm2jJE A==; X-CSE-ConnectionGUID: ozZapiraSCm4qjRr16qD1Q== X-CSE-MsgGUID: IyqEX1KHTF6H6dSos5xJhg== X-IronPort-AV: E=McAfee;i="6700,10204,11430"; a="48968605" X-IronPort-AV: E=Sophos;i="6.15,281,1739865600"; d="scan'208";a="48968605" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2025 00:21:06 -0700 X-CSE-ConnectionGUID: 0ko3IX0jT5myWjtqQ2lVbg== X-CSE-MsgGUID: WlHOkBL0Qz2iSHb+zLrwAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,281,1739865600"; d="scan'208";a="137142560" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2025 00:21:04 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uENTB-00000000qUl-1C0e; Mon, 12 May 2025 10:21:01 +0300 Date: Mon, 12 May 2025 10:21:01 +0300 From: Andy Shevchenko To: Jason Xing Cc: Andrew Morton , corbet@lwn.net, linux-doc@vger.kernel.org, LKML , linux@treblig.org, viro@zeniv.linux.org.uk, Jens Axboe Subject: Re: [PATCH] relay: Remove unused relay_late_setup_files Message-ID: References: Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, May 12, 2025 at 02:53:56PM +0800, Jason Xing wrote: > On Mon, May 12, 2025 at 2:15 PM Andy Shevchenko > wrote: > > On Mon, May 12, 2025 at 09:12:56AM +0800, Jason Xing wrote: > > > > > > I noticed this patch "relay: Remove unused relay_late_setup_files" > > > appears in the mm branch already[1], which I totally missed. Sorry for > > > joining the party late. > > > > > > I have a different opinion on this. For me, I'm very cautious about > > > what those so-called legacy interfaces are and how they can work in > > > different cases and what the use case might be... There are still a > > > small number of out-of-tree users like me heavily relying on relayfs > > > mechanism. So my humble opinion is that if you want to remove > > > so-called dead code, probably clearly state why it cannot be used > > > anymore in the future. > > > > > > Dr. David, I appreciate your patch, but please do not simply do the > > > random cleanup work __here__. If you take a deep look at the relayfs, > > > you may find there are other interfaces/functions no one uses in the > > > kernel tree. > > > > > > I'm now checking this kind of patch in relayfs one by one to avoid > > > such a thing happening. I'm trying to maintain it as much as possible > > > since we internally use it in the networking area to output useful > > > information in the hot paths, a little bit like blktrace. BTW, relayfs > > > is really a wonderful one that helps kernel modules communicate with > > > userspace very efficiently. I'm trying to revive it if I can. > > > > Jason, with all of the respect, if you are interested in keeping things going > > on, please add yourself to the MAINTAINERS. It will makes the users of the > > legacy code, Andrew and others, who are doing maintainer's/reviewer's job, > > and you happy. > > I didn't subscribe to LKML because they're too many emails everyday. > Because of this, I missed most of changes in relayfs. And how is this relevant to my proposal? Moreover with `lei` you can filter out from time to time the lore archive for these, no need to be subscribed and read LKML in full. > Sure, I'm happy to do so, but I'm not sure how/what the detailed > process is here. I would like to ask the core maintainers/developers > in advance. > > Any thoughts on this? Andrew, Jens. Just send a patch to the LKML which adds a relevant record into MAINTAINERS. I believe all stakeholders here will be happy to accept that kind of change. At least you can get my Ack, FWIW (I am not a stakeholder here). > > Also note, we usually do not care about the out-of-tree users. The main Q here > > why are they out-of-tree for so long time? > > It's due to the history problem. Back then, developers were trying to > develop various file systems to add more debuginfo. As you may notice, > blktrace is the one which manifests the answer. Then provide a roadmap on the upstreaming the necessary parts. Otherwise there is no room for a dead code in the Linux kernel. This is the rule: we do not add one, and we do not leave it dangling after removing the last user. > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything&id=46aa76118ee365c25911806e34d28fc2aa5ef997 -- With Best Regards, Andy Shevchenko