From: Patrick Steinhardt <ps@pks.im>
To: Lidong Yan via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Lidong Yan <502024330056@smail.nju.edu.cn>
Subject: Re: [PATCH] builtin/am: fix memory leak in `split_mail_stgit_series`
Date: Mon, 12 May 2025 10:10:10 +0200 [thread overview]
Message-ID: <aCGs4nRjjHAs6aYu@pks.im> (raw)
In-Reply-To: <pull.1961.git.git.1747015647505.gitgitgadget@gmail.com>
On Mon, May 12, 2025 at 02:07:27AM +0000, Lidong Yan via GitGitGadget wrote:
> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>
> In builtin/am.c:split_mail_stgit_series, if `fopen` failed,
> `series_dir_buf` allocated by `xstrdup` will leak. Add `free` in
> `!fp` if branch will prevent the leak.
>
> Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
This fix looks obviously correct to me. Thanks!
Patrick
next prev parent reply other threads:[~2025-05-12 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 2:07 [PATCH] builtin/am: fix memory leak in `split_mail_stgit_series` Lidong Yan via GitGitGadget
2025-05-12 8:10 ` Patrick Steinhardt [this message]
2025-05-12 14:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCGs4nRjjHAs6aYu@pks.im \
--to=ps@pks.im \
--cc=502024330056@smail.nju.edu.cn \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.