From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D868C3ABC3 for ; Mon, 12 May 2025 08:38:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F3C58805D7; Mon, 12 May 2025 10:38:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="RT/EESQy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 31A638294C; Mon, 12 May 2025 10:38:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AE4EF805D7 for ; Mon, 12 May 2025 10:38:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=andriy.shevchenko@linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747039117; x=1778575117; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xrolwI6XmwNF9StD66/zOUKbJinmGRgegfAyNqMKYA0=; b=RT/EESQy0Qwp7u3McbH4qKKLa1gbL1GCLv+xREjXPS1OiGCehJA+CkCn kbMIYqBFc0fYQYjoqV/kWiLkl60pP3UM3bxGEY//VuiQuQ8JUFN3OCRh9 OxZl+Q2DO66mfA/s3PCUqzWFUJ1tXEJ/ADW+Uhz45VOFQi79FgcBCvQDF w9tmA/+Pa65C7ADNuCVYFvZ8BsjZN4l98OfYiMiyJSspUaRxPnCdix3OD 8QzOVk8y3MiHwbxPJlzjohhjwqUj308vV8jJxcbZM78am7kU9ZlTEhuqB PTD1CCq0hwNMPd9GhhWKKXEJZmz7BnmTwxPidqrz/O35gVfQP/ZVap4du Q==; X-CSE-ConnectionGUID: SY8K9ozXSOmc5Xs9u+1uXg== X-CSE-MsgGUID: 4KscBVYiSe6YHxun2Q+7TA== X-IronPort-AV: E=McAfee;i="6700,10204,11430"; a="52633955" X-IronPort-AV: E=Sophos;i="6.15,281,1739865600"; d="scan'208";a="52633955" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2025 01:38:35 -0700 X-CSE-ConnectionGUID: fdFfWLOTQc+UDuuyB3g49w== X-CSE-MsgGUID: zARr1/tZTtyT4QPBTJwhtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,281,1739865600"; d="scan'208";a="141347803" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2025 01:38:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uEOg8-00000000rbB-2R4i; Mon, 12 May 2025 11:38:28 +0300 Date: Mon, 12 May 2025 11:38:28 +0300 From: Andy Shevchenko To: Christoph Niedermaier Cc: "u-boot@lists.denx.de" , Christian Marangi , Heinrich Schuchardt , Ilias Apalodimas , Jerome Forissier , Joe Hershberger , Marek Vasut , Michal Simek , Patrick Delaunay , Rasmus Villemoes , Simon Glass , Tom Rini , Venkatesh Yadav Abbarapu Subject: Re: [PATCH V3 0/3] cmd: env: select: Add output for available environment targets Message-ID: References: <20250509190043.28641-1-cniedermaier@dh-electronics.com> <10712670b2bf422dbda67be449b0107a@dh-electronics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10712670b2bf422dbda67be449b0107a@dh-electronics.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, May 12, 2025 at 08:22:19AM +0000, Christoph Niedermaier wrote: > From: Andy Shevchenko > Sent: Monday, May 12, 2025 9:38 AM > > On Fri, May 09, 2025 at 09:00:40PM +0200, Christoph Niedermaier wrote: > >> Add the "-l" parameter to the "env select" command to print the available > >> environment targets, convert all argument parsing in the file nvedit.c to > >> getopt() and check that with unit tests. > >> > >> The first patch converts the parsing of arguments to getopt() for all env > >> commands. The second one adds unit tests for checking the env command. > >> These were used to check the env commands before and after the conversion. > >> The third patch adds the actual new parameter "-l" for the "env select" > >> command. > > > > What is the binary size increase with this change, please? > > I don't know exactly which binary size I should look at? > I have looked at the object file of nvedit.c: > > I built it with the config dh_imx6_defconfig. > > Before my patches: > $ ls -la cmd/nvedit.o > -rw-r--r-- 1 developer developer 57644 May 12 10:03 cmd/nvedit.o > > After my patches: > $ ls -la cmd/nvedit.o > -rw-r--r-- 1 developer developer 59292 May 12 10:06 cmd/nvedit.o > > So the increase is 1648 Bytes (+2.86%). U-Boot binary. And better to use bloat-o-meter script for that, it shows the breakdown in more precise terms. -- With Best Regards, Andy Shevchenko