From: Danilo Krummrich <dakr@kernel.org>
To: Lyude Paul <lyude@redhat.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Asahi Lina" <lina@asahilina.net>
Subject: Re: [PATCH 4/4] rust: drm: gem: Implement AlwaysRefCounted for all gem objects automatically
Date: Mon, 12 May 2025 14:24:16 +0200 [thread overview]
Message-ID: <aCHocJFyqSXU6Aam@pollux> (raw)
In-Reply-To: <20250501183717.2058109-5-lyude@redhat.com>
On Thu, May 01, 2025 at 02:33:19PM -0400, Lyude Paul wrote:
> Currently we are requiring AlwaysRefCounted in most trait bounds for gem
> objects, and implementing it by hand for our only current type of gem
> object. However, all gem objects use the same functions for reference
> counting - and all gem objects support reference counting.
>
> We're planning on adding support for shmem gem objects, let's move this
> around a bit by instead making IntoGEMObject require AlwaysRefCounted as a
> trait bound, and then provide a blanket AlwaysRefCounted implementation for
> any object that implements IntoGEMObject so all gem object types can use
> the same AlwaysRefCounted implementation. This also makes things less
> verbose by making the AlwaysRefCounted trait bound implicit for any
> IntoGEMObject bound.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Great idea!
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
next prev parent reply other threads:[~2025-05-12 12:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 18:33 [PATCH 0/4] drm: Rust GEM bindings cleanup Lyude Paul
2025-05-01 18:33 ` [PATCH 1/4] rust: drm: gem: Use NonNull for Object::dev Lyude Paul
2025-05-09 20:59 ` Daniel Almeida
2025-05-12 12:11 ` Danilo Krummrich
2025-05-01 18:33 ` [PATCH 2/4] rust: drm: gem: Refactor IntoGEMObject::from_gem_obj() to as_ref() Lyude Paul
2025-05-09 21:37 ` Daniel Almeida
2025-05-13 19:25 ` Lyude Paul
2025-05-13 21:22 ` Lyude Paul
2025-05-12 12:21 ` Danilo Krummrich
2025-05-01 18:33 ` [PATCH 3/4] rust: drm: gem: s/into_gem_obj()/as_gem_obj()/ Lyude Paul
2025-05-09 21:42 ` Daniel Almeida
2025-05-12 12:22 ` Danilo Krummrich
2025-05-01 18:33 ` [PATCH 4/4] rust: drm: gem: Implement AlwaysRefCounted for all gem objects automatically Lyude Paul
2025-05-09 21:47 ` Daniel Almeida
2025-05-12 12:24 ` Danilo Krummrich [this message]
2025-05-15 18:58 ` [PATCH 0/4] drm: Rust GEM bindings cleanup Danilo Krummrich
2025-05-15 19:05 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCHocJFyqSXU6Aam@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=alyssa@rosenzweig.io \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.