From: Keith Busch <kbusch@kernel.org>
To: John Meneghini <jmeneghi@redhat.com>
Cc: Bryan Gurney <bgurney@redhat.com>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
axboe@kernel.dk, mlombard@bsdbackstore.eu
Subject: Re: [PATCH 1/2] nvme: check duplicate unique identifiers in order
Date: Mon, 12 May 2025 10:12:29 -0600 [thread overview]
Message-ID: <aCId7XmLnrLWZPdk@kbusch-mbp> (raw)
In-Reply-To: <cec53fce-2f1d-4162-8685-ab7c56649953@redhat.com>
On Mon, May 12, 2025 at 11:18:58AM -0400, John Meneghini wrote:
> On 5/9/25 11:33 AM, Keith Busch wrote:
>
> > If those are not unique, they need to be blanked out to make sure we don't
> > expose these on the namespace's sysfs attributes.
>
> OK, we can add another patch that blanks out the lower precedent/invalid IDs.
>
> Will that work?
I think you'd have to blank out the non-unique ones, otherwise the
driver would export them.
And while I think that might work, this proposal didn't go over so well
last time it came up:
https://lore.kernel.org/linux-nvme/20250414111916.GB13225@lst.de/
next prev parent reply other threads:[~2025-05-12 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 15:16 [PATCH 1/2] nvme: check duplicate unique identifiers in order Bryan Gurney
2025-05-09 15:33 ` Keith Busch
2025-05-12 15:18 ` John Meneghini
2025-05-12 16:12 ` Keith Busch [this message]
2025-06-24 15:16 ` Keith Busch
2025-07-15 19:01 ` John Meneghini
2025-07-15 19:29 ` Keith Busch
2025-07-22 7:00 ` Hannes Reinecke
2025-07-22 11:58 ` Martin K. Petersen
2025-09-12 20:32 ` John Meneghini
2025-09-16 19:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCId7XmLnrLWZPdk@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=bgurney@redhat.com \
--cc=hch@lst.de \
--cc=jmeneghi@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@bsdbackstore.eu \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.