All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <stfomichev@gmail.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch,
	pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com,
	sdf@fomichev.me, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH net] bnxt_en: bring back rtnl_lock() in bnxt_fw_reset_task()
Date: Mon, 12 May 2025 16:43:12 -0700	[thread overview]
Message-ID: <aCKHkBnPmVwmpsh2@mini-arch> (raw)
In-Reply-To: <CACKFLikQtZ6c50q44Un-jQM4G2mvMf31Qp0+fRFUbNF9p9NJ_A@mail.gmail.com>

On 05/12, Michael Chan wrote:
> On Mon, May 12, 2025 at 7:20 AM Stanislav Fomichev <stfomichev@gmail.com> wrote:
> > Will the following work instead? netdev_ops_assert_locked should take
> > care of asserting either ops lock or rtnl lock depending on the device
> > properties.
> 
> It works for netif_set_real_num_tx_queues() but I also need to replace
> the ASSERT_RTNL() with netdev_ops_assert_locked(dev) in
> __udp_tunnel_nic_reset_ntf().

Sounds good!

  reply	other threads:[~2025-05-12 23:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12  6:37 [PATCH net] bnxt_en: bring back rtnl_lock() in bnxt_fw_reset_task() Michael Chan
2025-05-12 14:20 ` Stanislav Fomichev
2025-05-12 22:08   ` Michael Chan
2025-05-12 23:43     ` Stanislav Fomichev [this message]
2025-05-13  0:26       ` Jakub Kicinski
2025-05-13  1:14         ` Stanislav Fomichev
2025-05-13  5:41           ` Michael Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCKHkBnPmVwmpsh2@mini-arch \
    --to=stfomichev@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.