From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16F54C3ABD8 for ; Tue, 13 May 2025 06:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qi5I/WRUcI4v6ESjrurPMH7qXnMa5THJLqa8OCfnxMc=; b=FR8Abo32osqxryp8VEQY9dchSF F6hk3gv8pfQqf3vesKEZzwJWD1ypPjqpYbjYlW8YFhLYyETa3r4Hd4gXbsVacHozwSYVXfCgIpJRx WQSMQ9zQQ1P25rFdrpgQbEDGIhsdrWj+CMeTxIw5DRv56g4a3US9U/81qy/lhIKThMj8=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uEiiK-00067P-L4; Tue, 13 May 2025 06:02:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uEii3-00066x-Pu for linux-f2fs-devel@lists.sourceforge.net; Tue, 13 May 2025 06:01:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=A9+ePvYxBnyCpeSa++Q34/8DfLYzSgwHO2oMji9uOIQ=; b=dZnoEGghrR0RLNRXtg6J/0ns4Y 4VDP80HB1Jpe7KP0bGWvTjAn3+BIADW40l1F7/xLGndJ/CSYB9tw4ATTgYY+Gh5ohkc5CP5mG0G/M nn9HgfQ2al9tOIogjr6Rejkzg6MdtdsJ3byo+jnXkV7barpsT4JELnnFRor/bswDVMU4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=A9+ePvYxBnyCpeSa++Q34/8DfLYzSgwHO2oMji9uOIQ=; b=g6EAvOh5IviRhBOjdb2aXRzzbT tLwqhp9mCZbUK8pZ0fqnMCMp+y5KXCuC/HAswWC10/dlkYlrDN2gDHpAD/F70wVsPkBbn+B0QQjDA mWz/dhaL08OElZm175FeLEX4tRODP9qqO3VDCPIUWY/cdt5CtUtOe7TVokbCo5ZL6zLw=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uEihy-0007rW-Se for linux-f2fs-devel@lists.sourceforge.net; Tue, 13 May 2025 06:01:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A9+ePvYxBnyCpeSa++Q34/8DfLYzSgwHO2oMji9uOIQ=; b=QgWBWBZxk5kchoGsEbfFc5YWrc tsUszgBF82Jg6HPTRlcKrwDQmLalAjZ+ko+mhlrfLcsPf1BTzYxz6XeHZyR27xJ/26bgEXdC+6KQo TbYk8JfE2+DMkt+qKPq4v2b9RdodX7GtY7VjiIyKgif+f1Vu4Q2Zc9Qhrn7DSkUgWD02H8O/cT84J q8oda3E5fA349eQHdRw/Q/P843fKjXgFNviL756KpO3AJymNsazO845/BcPHtYCzpxdFn1XcQLLr2 LBgkZI2mTXv81xLStUpvcqEJgkuglhtwgnajJBKc6EZwvsp2bY3YYXxYCKBUjwr4FM6Zin4aPXNCa mOaIFYAA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEiho-0000000BSQc-1Rge; Tue, 13 May 2025 06:01:32 +0000 Date: Mon, 12 May 2025 23:01:32 -0700 From: Christoph Hellwig To: Chao Yu Message-ID: References: <20250513055721.2918793-1-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250513055721.2918793-1-chao@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1uEihy-0007rW-Se Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: use vmalloc instead of kvmalloc in .init_{, de}compress_ctx X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mm@kvack.org, jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, May 13, 2025 at 01:57:20PM +0800, Chao Yu wrote: > .init_{,de}compress_ctx uses kvmalloc() to alloc memory, it will try > to allocate physically continuous page first, it may cause more memory > allocation pressure, let's use vmalloc instead to mitigate it. Shouldn't this be handled in kvmalloc instead of working around it in callers? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56976C3ABC3 for ; Tue, 13 May 2025 06:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 053CE6B000A; Tue, 13 May 2025 02:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1E836B0083; Tue, 13 May 2025 02:01:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE6186B0085; Tue, 13 May 2025 02:01:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BBE8C6B000A for ; Tue, 13 May 2025 02:01:35 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7FE92140206 for ; Tue, 13 May 2025 06:01:36 +0000 (UTC) X-FDA: 83436837792.05.9ADB3C9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 34AE718000D for ; Tue, 13 May 2025 06:01:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QgWBWBZx; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+dca7e289515a8c765a4c+7933+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dca7e289515a8c765a4c+7933+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747116094; a=rsa-sha256; cv=none; b=2/Rodw9acJ6oGGwUSRX5iBvmnHUXQR7gKYDkp1WX2nvtS/LwxccBf612sdYU3QN5Goo4Ll QiNZ+rCut1wEeZZB3hsD0Ck8dU55iJK5LjorQE0z8nfXtl6gGarXEnJgMACNPUlQX5Lz9C tulc/cqBBVJ8NF2wqqh+M7lP6MotAO8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QgWBWBZx; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+dca7e289515a8c765a4c+7933+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dca7e289515a8c765a4c+7933+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747116094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A9+ePvYxBnyCpeSa++Q34/8DfLYzSgwHO2oMji9uOIQ=; b=5XuPb3YSjg/1VOSYx8uEAFZb7kM/+BF7TiVHxL6EnZI7rnFbOLf0EuNMbgfLUFlOgCDHW6 MmT/gPz7u9hRPzTRapwuhJjVf8Qzf9ooDtYW9CcBke9v8CFqYwDeWph9BnI6emuMFwxy9H rAW6wCsMevoe7nSF31rYZSz8S4jEMnA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A9+ePvYxBnyCpeSa++Q34/8DfLYzSgwHO2oMji9uOIQ=; b=QgWBWBZxk5kchoGsEbfFc5YWrc tsUszgBF82Jg6HPTRlcKrwDQmLalAjZ+ko+mhlrfLcsPf1BTzYxz6XeHZyR27xJ/26bgEXdC+6KQo TbYk8JfE2+DMkt+qKPq4v2b9RdodX7GtY7VjiIyKgif+f1Vu4Q2Zc9Qhrn7DSkUgWD02H8O/cT84J q8oda3E5fA349eQHdRw/Q/P843fKjXgFNviL756KpO3AJymNsazO845/BcPHtYCzpxdFn1XcQLLr2 LBgkZI2mTXv81xLStUpvcqEJgkuglhtwgnajJBKc6EZwvsp2bY3YYXxYCKBUjwr4FM6Zin4aPXNCa mOaIFYAA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEiho-0000000BSQc-1Rge; Tue, 13 May 2025 06:01:32 +0000 Date: Mon, 12 May 2025 23:01:32 -0700 From: Christoph Hellwig To: Chao Yu Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] f2fs: use vmalloc instead of kvmalloc in .init_{,de}compress_ctx Message-ID: References: <20250513055721.2918793-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250513055721.2918793-1-chao@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 34AE718000D X-Stat-Signature: zyc7eohqi5z8noa5qm8gshdxpqkighkh X-HE-Tag: 1747116094-707714 X-HE-Meta: U2FsdGVkX18JBLX4p7ii1XodHLdkNXiElY1WrqtgpERMOAe01niIQ3BnyK/6wiyrEZKsz7mjLu0Wvv6OdJDdlq0fCuZTPeaCp4FvTY/MbKxQE1F9dea0I7BIjn8TcQADwdi9/o9/147o2SZzFNDyeimuMW7bV/U0IdKIh1+lk/xqALZe43CunvkmN4QV7cnFRJmUcmmCQw1SJXW8WZR/aW3+fMGfp9or6kOufQ3fF94aNW4EkmXgKz+UXQ7p7t0E82BmQoE7FQjBBq0eTYzC8H5eLZIW5oYD+8ieCRwVWE7Z3j30Y8VAr1HOZwd8SGPcOIuKTf0Ac5Q8Gj7KwS8uqOYUFFW1vrcxjNpQRZou628SQJTHqyvjhmmU4UaNvKTNgFMjeJZcMPovUPgCoO6rspPgPIpf2tvtbhfD6ZaEORiWwIxXZd6gdTNwd79mXbXPjHmYMdjxeIde6eZYbAv5t+Oze/VPpPlPMIYhlOTHKEZC17NNcM0A4az5l/+6CgDtHLD2PQm4ShAjA2WB6BgvKTzHrmYj0GqVu7/zTnuQrNWi3Y6hrh23seW8EZplsWjIDgsg0wObYpaIj0vDsjb/nBTW28IgaQR5UtdgFckUz87zm5sxDVo+WeQQWqgsA8XTCLsMSMa98E6hcUmKOYpRitbhpCrjr8WV3QY8YuoMk6SrVjFDjBgCYysC9rZ9CgCT50Cw/nyJ2uALoRcZd6pM8Ftthi2SwCBqaQqSYZAbLzrl5DTYdRffDchlxqHTvb6y7/fQDGA21J2LBQQeG+lqStMptr1OfJbjvmbMaoRHwzcV5RSw3VrFt4bJFnJB8iMYA+2t4KktkXgzVWKPWTshBPGZwRVSBv54T8SC1h+XcUnUu6hXzFUmPKCZ1mkJhLKUepoKZ1lKQ4lS2NJCb34DJ4gMG+LH+CaBUeNmP25IXUjnuzL8nTzNeqB49lNTOL+FTKDNX6Ohjf9szKIHdQg PnAGZqQr Jj83l4/jXnx8GIm5drxwQzyjtBReCPwkuXF431oWoO/MjF4OFn/377gRnO2xrPvlCaBSZO8YzKPesQWku5h7dUs79dp8iAGm/j7PqmG6BV8z+G9NtlU0wuOM9E665KQDGaHvwFHM8lFNxO4xUb8TMlm1rD9UbH+leItt6vjVYJSvQiFAJQvnwNvIcF1WS46K1y9rpMaZfX9cgqxi7vAIUUSzhHciJYGdS7uYl+U7ZSLtT8rZA+AYZVFpZsXFZPNoGSBAefvwJJ1dSEA3okqD6vBeo+2OkWWW7Q2vipoXsdB0FM+z97zp1lWkCDbl4KWnqg/JX62eniZa8y98Koctj8Z7A3SC5oqW0gy0JtZE5h6XYQU8QHLsAya6XB+kZmupm/2wNlebVqt8lPP2RXVmL6UqsmCrLi7acD0Qx7OSF+Z7Y9ab0WQSNXIzvlEuYZCiT5x079MTe2NHupQsIrmK4NGRPbAtbKZxV3q5xK7P5vh0TRSsaiwS7Q0khOIVfZoA19iAvWlWPYCOAsE4jL1bDNsZScg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 01:57:20PM +0800, Chao Yu wrote: > .init_{,de}compress_ctx uses kvmalloc() to alloc memory, it will try > to allocate physically continuous page first, it may cause more memory > allocation pressure, let's use vmalloc instead to mitigate it. Shouldn't this be handled in kvmalloc instead of working around it in callers?