From: Matt Bobrowski <mattbobrowski@google.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Viktor Malik <vmalik@redhat.com>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH bpf-next v4 1/4] bpf: Teach vefier to handle const ptrs as args to kfuncs
Date: Tue, 13 May 2025 06:48:11 +0000 [thread overview]
Message-ID: <aCLrK_QBMVWCy4bo@google.com> (raw)
In-Reply-To: <CAADnVQJD3dQfuT2ExXL5iGeVj0TJ9L5KWGovmsSz5giKft4ryQ@mail.gmail.com>
On Fri, May 09, 2025 at 09:20:53AM -0700, Alexei Starovoitov wrote:
> On Thu, May 8, 2025 at 2:09 AM Matt Bobrowski <mattbobrowski@google.com> wrote:
> >
> > >
> > > static int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg,
> > > - u32 regno, u32 mem_size)
> > > + u32 regno, u32 mem_size, bool read_only)
> >
> > Maybe s/read_only/write_mem_access?
>
> 'bool' arguments are not readable at the callsite.
> Let's use enum bpf_access_type BPF_READ|WRITE here
> or introduce another enum ?
Yes, I agree, and using enum bpf_access_type is also something that
had crossed my mind. I think that's what should be used here in favour
of the boolean.
next prev parent reply other threads:[~2025-05-13 6:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 6:40 [PATCH bpf-next v4 0/4] bpf: Add kfuncs for read-only string operations Viktor Malik
2025-05-07 6:40 ` [PATCH bpf-next v4 1/4] bpf: Teach vefier to handle const ptrs as args to kfuncs Viktor Malik
2025-05-08 9:08 ` Matt Bobrowski
2025-05-09 16:20 ` Alexei Starovoitov
2025-05-13 6:48 ` Matt Bobrowski [this message]
2025-05-13 7:54 ` Viktor Malik
2025-05-13 14:58 ` Alexei Starovoitov
2025-05-13 7:58 ` Viktor Malik
2025-05-07 6:40 ` [PATCH bpf-next v4 2/4] uaccess: Define pagefault lock guard Viktor Malik
2025-05-08 10:00 ` Matt Bobrowski
2025-05-09 18:20 ` Andrii Nakryiko
2025-05-13 6:55 ` Matt Bobrowski
2025-05-07 6:40 ` [PATCH bpf-next v4 3/4] bpf: Add kfuncs for read-only string operations Viktor Malik
2025-05-08 9:41 ` Matt Bobrowski
2025-05-09 16:39 ` Alexei Starovoitov
2025-05-28 9:05 ` Viktor Malik
2025-05-15 12:32 ` Viktor Malik
2025-05-09 18:20 ` Andrii Nakryiko
2025-05-09 21:37 ` Eduard Zingerman
2025-05-09 22:03 ` Andrii Nakryiko
2025-05-15 12:27 ` Viktor Malik
2025-05-15 17:17 ` Andrii Nakryiko
2025-05-16 5:59 ` Viktor Malik
2025-05-16 15:50 ` Andrii Nakryiko
2025-05-07 6:40 ` [PATCH bpf-next v4 4/4] selftests/bpf: Add tests for string kfuncs Viktor Malik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCLrK_QBMVWCy4bo@google.com \
--to=mattbobrowski@google.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=vmalik@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.