From: Joerg Roedel <joro@8bytes.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
linux-pci@vger.kernel.org, iommu@lists.linux.dev,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 1/2] Revert "iommu/amd: Prevent binding other PCI drivers to IOMMU PCI devices"
Date: Tue, 13 May 2025 09:08:29 +0200 [thread overview]
Message-ID: <aCLv7cN_s1Z4abEl@8bytes.org> (raw)
In-Reply-To: <9a3ddff5cc49512044f963ba0904347bd404094d.1745572340.git.lukas@wunner.de>
On Fri, Apr 25, 2025 at 11:24:21AM +0200, Lukas Wunner wrote:
> Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and
> pcibios_free_irq()") changed IRQ handling on PCI driver probing.
> It inadvertently broke resume from system sleep on AMD platforms:
>
> https://lore.kernel.org/r/20150926164651.GA3640@pd.tnic/
>
> This was fixed by two independent commits:
>
> * 8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled")
> * cbbc00be2ce3 ("iommu/amd: Prevent binding other PCI drivers to IOMMU
> PCI devices")
>
> The breaking change and one of these two fixes were subsequently reverted:
>
> * fe25d078874f ("Revert "x86/PCI: Don't alloc pcibios-irq when MSI is
> enabled"")
> * 6c777e8799a9 ("Revert "PCI, x86: Implement pcibios_alloc_irq() and
> pcibios_free_irq()"")
>
> This rendered the second fix unnecessary, so revert it as well. It used
> the match_driver flag in struct pci_dev, which is internal to the PCI core
> and not supposed to be touched by arbitrary drivers.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Acked-by: Joerg Roedel <jroedel@suse.de>
next prev parent reply other threads:[~2025-05-13 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 9:24 [PATCH 0/2] PCI: Clean up match_driver flag usage Lukas Wunner
2025-04-25 9:24 ` [PATCH 1/2] Revert "iommu/amd: Prevent binding other PCI drivers to IOMMU PCI devices" Lukas Wunner
2025-05-12 13:28 ` Lukas Wunner
2025-05-13 7:08 ` Joerg Roedel [this message]
2025-04-25 9:24 ` [PATCH 2/2] PCI: Limit visibility of match_driver flag to PCI core Lukas Wunner
2025-04-25 16:32 ` [PATCH 0/2] PCI: Clean up match_driver flag usage Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCLv7cN_s1Z4abEl@8bytes.org \
--to=joro@8bytes.org \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.