All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] gitlab-ci: always run MSVC-based Meson job
Date: Tue, 13 May 2025 11:12:57 +0200	[thread overview]
Message-ID: <aCMNGUlfBcafn97s@pks.im> (raw)
In-Reply-To: <20250428-pks-gitlab-ci-execute-win-meson-v1-1-f68683552b9e@pks.im>

On Mon, Apr 28, 2025 at 11:32:12AM +0200, Patrick Steinhardt wrote:
> With 7304bd2bc39 (ci: wire up Visual Studio build with Meson,
> 2025-01-22) we have introduced a CI job that builds and tests Git with
> Microsoft Visual Studio via Meson. This job is only being executed by
> default on GitHub Workflows though -- on GitLab CI it is marked as a
> "manual" job, so the developer has to actively trigger these jobs.
> 
> The consequence of this split is that any breakage specific to this job
> is only noticed by developers who mainly work with GitHub. Let's improve
> this situation by also running the job by default on GitLab CI.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>

While there has been discussion around whether we can in general avoid
some duplication in our pipelines, I think this patch makes sense
regardless to bring GitLab CI in line with GitHub Workflows. I haven't
seen the patch being picked up yet though -- I assume it fell of the
radar.

Junio, do you have any concern with taking this patch?

Thanks!

  parent reply	other threads:[~2025-05-13  9:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28  9:32 [PATCH] gitlab-ci: always run MSVC-based Meson job Patrick Steinhardt
2025-04-28 10:59 ` Johannes Schindelin
2025-04-28 18:44   ` Junio C Hamano
2025-05-06 10:39     ` Patrick Steinhardt
2025-05-06 13:17       ` Phillip Wood
2025-05-13  9:12 ` Patrick Steinhardt [this message]
2025-05-13 17:03   ` Junio C Hamano
2025-05-14  2:16     ` Patrick Steinhardt
2025-05-14 16:55       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCMNGUlfBcafn97s@pks.im \
    --to=ps@pks.im \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.