From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433F71D515A for ; Tue, 13 May 2025 15:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747150888; cv=none; b=Rcq0is9zAJgICPj2C4qR8zfGXpMH45vL4FPLwAGXlQ//27IE5MhF5Iw/KBx+HJKosWk8yZxoLM6S4eXkY4FBfZTtJ3pNlSHZOXM6WV57ppswD45Mrd7XqkTEmxtHVqGXdgH8JFk0qTXIVTOrV5Qwid/k4Y/ClBLB2TB/cA7GW0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747150888; c=relaxed/simple; bh=q9qfQ1rhIUH7j0QWiIny1L7a1bXoBjy1kEQM+qC0wKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lFX7A9C5AOW6S1y87sPeoAmNiNidH3D/vxHxeWZUKNYJHqpD8FZbxmGtniACOCGb2duMdJmCjHqsy33RnxTtLTK5UHWjqxJQ/iEAhyVq1AnrLGZ6jaSOGulcB8AAXLsIlUJ92D99SFUMI9Zc0J7pJuX+tIxqub/W2PL3dwJUZnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gLDBX6ZN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gLDBX6ZN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747150885; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cmcBme9RJOCaIz52I3Nem99kp82JzzM+3hYCaD81L68=; b=gLDBX6ZN14TPIBkLAkA7cQdm8k7eorokC8BUcPwzob9BXdzRNsiIr4WlVdTZ6PqIk0PZwn oVq8ArwdchN0FJMljpTOXxnFqXCB3++Zg7fTxf3g2GNs4VgNVjDBqj2x2RAtTqSBYUYkNO TUJmCZPTe9B5wcOSUy/QQsxQXQejE5U= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-kY9XtUMzOoagtJuJDj4qRA-1; Tue, 13 May 2025 11:41:21 -0400 X-MC-Unique: kY9XtUMzOoagtJuJDj4qRA-1 X-Mimecast-MFC-AGG-ID: kY9XtUMzOoagtJuJDj4qRA_1747150879 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AB0531956086; Tue, 13 May 2025 15:41:18 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.110]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A681E1953B82; Tue, 13 May 2025 15:41:10 +0000 (UTC) Date: Tue, 13 May 2025 16:41:06 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Cornelia Huck Cc: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvmarm@lists.linux.dev, peter.maydell@linaro.org, richard.henderson@linaro.org, alex.bennee@linaro.org, maz@kernel.org, oliver.upton@linux.dev, sebott@redhat.com, shameerali.kolothum.thodi@huawei.com, armbru@redhat.com, abologna@redhat.com, jdenemar@redhat.com, agraf@csgraf.de, shahuang@redhat.com, mark.rutland@arm.com, philmd@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH for-10.1 v5 02/13] arm/cpu: Store aa64isar0/aa64zfr0 into the idregs arrays Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20250409144304.912325-1-cohuck@redhat.com> <20250409144304.912325-3-cohuck@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250409144304.912325-3-cohuck@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 On Wed, Apr 09, 2025 at 04:42:53PM +0200, Cornelia Huck wrote: > From: Eric Auger > > Also add kvm add accessors for storing host features into idregs. > > Reviewed-by: Richard Henderson > Reviewed-by: Sebastian Ott > Signed-off-by: Eric Auger > Signed-off-by: Cornelia Huck > --- > target/arm/cpu-features.h | 57 ++++++++++++++++++++------------------- > target/arm/cpu-sysregs.h | 4 +++ > target/arm/cpu.c | 10 +++---- > target/arm/cpu.h | 2 -- > target/arm/cpu64.c | 8 +++--- > target/arm/helper.c | 6 +++-- > target/arm/hvf/hvf.c | 3 ++- > target/arm/kvm.c | 30 ++++++++++++++++++--- > target/arm/tcg/cpu64.c | 44 ++++++++++++++++++------------ > 9 files changed, 101 insertions(+), 63 deletions(-) > diff --git a/target/arm/cpu-sysregs.h b/target/arm/cpu-sysregs.h > index 7877a3b06a8e..e89a1105904c 100644 > --- a/target/arm/cpu-sysregs.h > +++ b/target/arm/cpu-sysregs.h > @@ -39,4 +39,8 @@ extern const uint32_t id_register_sysreg[NUM_ID_IDX]; > > int get_sysreg_idx(ARMSysRegs sysreg); > > +#ifdef CONFIG_KVM > +uint64_t idregs_sysreg_to_kvm_reg(ARMSysRegs sysreg); > +#endif This breaks the build when KVM is disabled, and/or not available on the build target architecture In file included from ../target/arm/cpu.h:35, from /var/home/berrange/src/virt/qemu/include/hw/arm/digic.h:21, from ../hw/arm/digic_boards.c:31: /var/home/berrange/src/virt/qemu/target/arm/cpu-sysregs.h:42:8: error: attempt to use poisoned ‘CONFIG_KVM’ 42 | #ifdef CONFIG_KVM | ^ In file included from /var/home/berrange/src/virt/qemu/include/exec/poison.h:7, from /var/home/berrange/src/virt/qemu/include/qemu/osdep.h:38, from ../hw/arm/digic_boards.c:26: ./config-poison.h:185:20: note: poisoned here 185 | #pragma GCC poison CONFIG_KVM | ^~~~~~~~~~ ninja: build stopped: subcommand failed. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|