Re: [PATCH v11 0/3] Allow to enable multifd and postcopy migration together

[Peter Xu <peterx@redhat.com>]

On Mon, May 12, 2025 at 06:21:21PM +0530, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@fedoraproject.org>
> 
>  Hello,
> 
> * This series (v11) fixes spelling and capitalisations glitches and
>   does some refactoring and reordering changes as suggested in the
>   review of v10.
> ===
> 67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test                 OK             196.69s   81 subtests passed
> ===

I queued it with some renames in the last test file, the fixup attached,
please let me know if anyone sees any issues.

In general, I put all the new tests under /migration/multifd+postcopy/,
rather than using different path.

Thanks,

===8<===

From 89c22f1c5fbb4afdf5bf3f3b0ef2dae162094488 Mon Sep 17 00:00:00 2001
From: Peter Xu <peterx@redhat.com>
Date: Tue, 13 May 2025 17:46:24 -0400
Subject: [PATCH] fixup! tests/qtest/migration: add postcopy tests with multifd

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 tests/qtest/migration/postcopy-tests.c | 4 ++--
 tests/qtest/migration/tls-tests.c      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/qtest/migration/postcopy-tests.c b/tests/qtest/migration/postcopy-tests.c
index eb637f94f7..3773525843 100644
--- a/tests/qtest/migration/postcopy-tests.c
+++ b/tests/qtest/migration/postcopy-tests.c
@@ -137,9 +137,9 @@ void migration_test_add_postcopy(MigrationTestEnv *env)
             "/migration/postcopy/recovery/double-failures/reconnect",
             test_postcopy_recovery_fail_reconnect);
 
-        migration_test_add("/migration/postcopy/multifd/plain",
+        migration_test_add("/migration/multifd+postcopy/plain",
                            test_multifd_postcopy);
-        migration_test_add("/migration/postcopy/multifd/preempt/plain",
+        migration_test_add("/migration/multifd+postcopy/preempt/plain",
                            test_multifd_postcopy_preempt);
         if (env->is_x86) {
             migration_test_add("/migration/postcopy/suspend",
diff --git a/tests/qtest/migration/tls-tests.c b/tests/qtest/migration/tls-tests.c
index 50a07a1c0f..46b48ef78c 100644
--- a/tests/qtest/migration/tls-tests.c
+++ b/tests/qtest/migration/tls-tests.c
@@ -816,9 +816,9 @@ void migration_test_add_tls(MigrationTestEnv *env)
                            test_postcopy_preempt_tls_psk);
         migration_test_add("/migration/postcopy/preempt/recovery/tls/psk",
                            test_postcopy_preempt_all);
-        migration_test_add("/migration/postcopy/multifd/recovery/tls/psk",
+        migration_test_add("/migration/multifd+postcopy/recovery/tls/psk",
                            test_multifd_postcopy_recovery_tls_psk);
-        migration_test_add("/migration/postcopy/multifd/preempt/recovery/tls/psk",
+        migration_test_add("/migration/multifd+postcopy/preempt/recovery/tls/psk",
                            test_multifd_postcopy_preempt_recovery_tls_psk);
     }
 #ifdef CONFIG_TASN1
-- 
2.49.0


-- 
Peter Xu