From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] lib: initialize lib|main_pid to zero in the setup_ipc
Date: Wed, 14 May 2025 10:23:33 +0200 [thread overview]
Message-ID: <aCRTBfIRoj0rhhX3@yuki.lan> (raw)
In-Reply-To: <CAEemH2f8TVDozK+UJDrtekwNqk7AM2MZZu8Mq8VDrkvyyu50LA@mail.gmail.com>
Hi!
> I see, and you're right we have to set lib_pid before any real setup.
>
> Does this change below make sense (based on the v2 I just sent)?
>
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -144,6 +144,8 @@ static void setup_ipc(void)
> }
>
> memset(results, 0 , size);
> +
> + results->lib_pid = getpid();
> }
>
> static void cleanup_ipc(void)
> @@ -1933,7 +1935,6 @@ void tst_run_tcases(int argc, char *argv[],
> struct tst_test *self)
>
> do_setup(argc, argv);
>
> - results->lib_pid = getpid();
> tst_enable_oom_protection(results->lib_pid);
>
> SAFE_SIGNAL(SIGALRM, alarm_handler);
Yes, this should fix it.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-14 8:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 5:05 [LTP] [PATCH 1/2] lib: initialize lib|main_pid to zero in the setup_ipc Li Wang via ltp
2025-05-13 5:05 ` [LTP] [PATCH 2/2] dirtyc0w_shmem: set child_needs_reinit Li Wang via ltp
2025-05-13 20:31 ` Wei Gao via ltp
2025-05-13 9:33 ` Li Wang via ltp
2025-05-13 12:09 ` Cyril Hrubis
2025-05-13 12:08 ` [LTP] [PATCH 1/2] lib: initialize lib|main_pid to zero in the setup_ipc Cyril Hrubis
2025-05-13 12:42 ` Li Wang via ltp
2025-05-14 8:00 ` Cyril Hrubis
2025-05-14 8:18 ` Li Wang via ltp
2025-05-14 8:23 ` Cyril Hrubis [this message]
2025-05-13 12:51 ` Petr Vorel
2025-05-13 13:02 ` Li Wang via ltp
2025-05-13 13:06 ` Li Wang via ltp
2025-05-13 15:41 ` Petr Vorel
2025-05-14 1:14 ` Li Wang via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCRTBfIRoj0rhhX3@yuki.lan \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.