All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	qemu-s390x@nongnu.org
Subject: Re: [PATCH 8/9] target/s390x/kvm/pv: Consolidate OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
Date: Wed, 14 May 2025 23:53:12 +0800	[thread overview]
Message-ID: <aCS8aHsF+VAuj01D@intel.com> (raw)
In-Reply-To: <e0146386-ccf4-44ba-b58f-0bb4d3317f89@redhat.com>

> > +OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES(S390PVGuest,
> > +                                          s390_pv_guest,
> > +                                          S390_PV_GUEST,
> > +                                          CONFIDENTIAL_GUEST_SUPPORT,
> > +                                          { TYPE_USER_CREATABLE },
> > +                                          { NULL })
> 
> I'll note that existing callers of OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
> happily ignore the line limit and put it into a single line.
> 
> (which ends up looking better IMHO)

Ok, I'll onor the existing conventions (which I'll apply to other
patches as well).

> Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks!

Regards,
Zhao



  reply	other threads:[~2025-05-14 15:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14  8:49 [PATCH 0/9] qom: Consolidate OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE* Zhao Liu
2025-05-14  8:49 ` [PATCH 1/9] qom/object: Improve the doc of macros related with simple type Zhao Liu
2025-05-14 12:02   ` BALATON Zoltan
2025-05-14 15:32     ` Zhao Liu
2025-05-14 16:13       ` BALATON Zoltan
2025-05-15 14:01         ` Zhao Liu
2025-05-14  8:49 ` [PATCH 2/9] docs/devel/qom: Fix the doc about OBJECT_DECLARE_SIMPLE_TYPE Zhao Liu
2025-05-14 12:06   ` BALATON Zoltan
2025-05-14 15:45     ` Zhao Liu
2025-05-14 16:16       ` BALATON Zoltan
2025-05-15 14:04         ` Zhao Liu
2025-05-14  8:49 ` [PATCH 3/9] hw/acpi/pci: Consolidate OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES Zhao Liu
2025-05-14 13:08   ` Ani Sinha
2025-05-14  8:49 ` [PATCH 4/9] hw/char/sh_serial: " Zhao Liu
2025-05-14 12:07   ` BALATON Zoltan
2025-05-14 15:46     ` Zhao Liu
2025-05-14  8:49 ` [PATCH 5/9] hw/hyperv/hv-balloon: " Zhao Liu
2025-05-19 14:10   ` Maciej S. Szmigiero
2025-05-14  8:49 ` [PATCH 6/9] hw/ppc/pef: " Zhao Liu
2025-05-14 11:46   ` BALATON Zoltan
2025-05-14 11:59     ` BALATON Zoltan
2025-05-14  8:49 ` [PATCH 7/9] hw/core/resetcontainer: Consolidate OBJECT_DECLARE_SIMPLE_TYPE Zhao Liu
2025-05-14 16:56   ` Philippe Mathieu-Daudé
2025-05-14  8:49 ` [PATCH 8/9] target/s390x/kvm/pv: Consolidate OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES Zhao Liu
2025-05-14  8:51   ` David Hildenbrand
2025-05-14 15:53     ` Zhao Liu [this message]
2025-05-14 16:24       ` BALATON Zoltan
2025-05-15 13:50         ` Zhao Liu
2025-05-15 15:41           ` BALATON Zoltan
2025-05-15 16:11             ` Daniel P. Berrangé
2025-05-16  3:23               ` Zhao Liu
2025-05-16  7:47                 ` David Hildenbrand
2025-05-14  8:49 ` [PATCH 9/9] ui/console-vc: Consolidate OBJECT_DEFINE_SIMPLE_TYPE Zhao Liu
2025-05-14 16:55   ` Philippe Mathieu-Daudé
2025-05-31 17:36 ` [PATCH 0/9] qom: Consolidate OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE* Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCS8aHsF+VAuj01D@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=iii@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.