Re: [PATCH v2 6/7] scripts/checkpatch: use new hook for MAINTAINERS update check

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, May 14, 2025 at 01:51:52PM +0200, Cédric Le Goater wrote:
> On 5/12/25 20:24, Daniel P. Berrangé wrote:
> > From: Daniel P. Berrangé <berrange@redhat.com>
> > 
> > When seeing a new/deleted/renamed file we check to see if MAINTAINERS
> > is updated, but we don't give the user a list of files affected, as
> > we don't want to repeat the same warning many times over.
> > 
> > Using the new file list hook, we can give a single warning at the
> > end with a list of filenames included.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   scripts/checkpatch.pl | 37 +++++++++++++++++++------------------
> >   1 file changed, 19 insertions(+), 18 deletions(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 4a18daa384..d416a6dcf9 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1442,6 +1442,25 @@ sub process_file_list {
> >   		      join("\n  ", @acpi_nontestexpected) .
> >   		      "\n\nfound in the same patch\n");
> >   	}
> > +
> > +	my $sawmaintainers = 0;
> > +	my @maybemaintainers;
> > +	foreach my $fileinfo (@fileinfos) {
> > +		if ($fileinfo->{action} ne "modified" &&
> > +		    $fileinfo->{filenew} !~ m#^tests/data/acpi/#) {
> > +			push @maybemaintainers, $fileinfo->{filenew};
> > +		}
> > +		if ($fileinfo->{filenew} eq "MAINTAINEfRS") {
> 
> MAINTAINEfRS ? looks like a typo.

Opps, an intentional typo when I was testing logic that
I accidentally committed.

> 
> 
> With that fixed,
> 
> 
> Reviewed-by: Cédric Le Goater <clg@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|